Skip to content

道馆任务每次运行时尝试开启道馆 - #1975

Merged
runhey merged 1 commit into
runhey:devfrom
weirj2016-ai:fix/dokan-create-every-run-dev
Oct 28, 2026
Merged

runhey merged 1 commit into
runhey:devfrom
weirj2016-ai:fix/dokan-create-every-run-dev

Conversation

@weirj2016-ai

@weirj2016-ai weirj2016-ai commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

变更

  • 移除仅在周一调用 creat_dokan() 的限制。
  • 启用 try_start_dokan 且剩余挑战次数大于 0 时,每次任务进入“寻找道馆”阶段都会尝试开启道馆。
  • 保留 monday_to_thursday 等其他现有条件。

验证

  • git diff --check 通过。
  • 未运行自动化测试。

Summary by Sourcery

Enhancements:

  • 在启用道馆开启且仍有挑战次数的情况下,每次进入寻找道馆阶段时都会尝试开启道馆,不再仅限于周一。
Original summary in English

Summary by Sourcery

Enhancements:

  • 在满足启用道馆开启且仍有挑战次数的条件下,每次进入寻找道馆阶段都会尝试开启道馆,不再仅限于周一。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好——我已审查你的更改,整体看起来很棒!

Sourcery 评估

需要人工审查。 现在每次运行都会调用 creat_dokan,因此一次成功的尝试可能会在游戏中创建 dojo 状态;即使回滚这段代码,这些状态仍会保留。回滚可以阻止后续尝试,但已经创建的 dojo 需要另行处理。


Sourcery 对开源项目免费使用——如果你喜欢我们的审查,请考虑分享 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. Every run now calls creat_dokan, so a successful attempt may create dojo state in the game that remains after this code is reverted. Reverting stops future attempts, but any dojo already created would need to be handled separately.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@github-actions

Copy link
Copy Markdown
Contributor

Findings

  • C8 [不确定]
    位置:tasks/Dokan/script_task.py:140-147,PR 检查 Run
    原因:本次改动扩大了道馆创建的触发时机,但未提供自动化测试;当前 head 的 Run 检查已失败,无法证明非周一场景下创建、查找及退出流程均正常。
    修改:补充覆盖非周一且 try_start_dokan 开启、剩余挑战次数大于 0 的测试,并先定位修复失败的 Run 检查。

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Checklist for #1975 · codex · gpt56 · 10.6 AIC · ⌖ 2.6 AIC · ⊞ 12.1K · ◷

@runhey
runhey merged commit d345e96 into runhey:dev Oct 28, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants