Repository navigation
修复永生之海队员锁定阵容检查流程 - #1974
修复永生之海队员锁定阵容检查流程#1974
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿——我发现了 1 个问题
给 AI 代理的提示
请处理本次代码审查中的评论：
## 单条评论
### 评论 1
<location path="tasks/EternitySea/script_task.py" line_range="183" />
<code_context>
- layer = self._task_config.eternity_sea_config.layer
- self.check_layer(layer)
- self.check_lock(self._task_config.general_battle_config.lock_team_enable)
+ self._prepare_eternity_sea()
# 创建队伍
logger.info('Create team')
</code_context>
<issue_to_address>
**准备期间邀请会过期**
队长在队员准备期间发送邀请时（包括邀请弹窗遮挡锁定指示器的情况），`run_member()` 会等待 `_prepare_eternity_sea()` 返回后才调用 `check_then_accept()`；而当弹窗阻碍锁定状态检测时，`check_lock()` 可能会持续循环。结果是邀请过期，队长等待队员时最终超时。
请确保准备期间仍会接受邀请，并避免邀请弹窗导致锁定检查陷入无限循环。
另请检查 `tasks/EternitySea/script_task.py:44`。
</issue_to_address>Sourcery 评估
等待批准。 请先处理 1 项发现。
阻断性问题：tasks/EternitySea/script_task.py:183
Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tasks/EternitySea/script_task.py" line_range="183" />
<code_context>
- layer = self._task_config.eternity_sea_config.layer
- self.check_layer(layer)
- self.check_lock(self._task_config.general_battle_config.lock_team_enable)
+ self._prepare_eternity_sea()
# 创建队伍
logger.info('Create team')
</code_context>
<issue_to_address>
**Invitations expire during preparation**
When the leader sends an invitation while the member is preparing, including while an invitation overlay hides the lock indicator, `run_member()` waits for `_prepare_eternity_sea()` to return before calling `check_then_accept()`, and `check_lock()` can keep looping when the overlay prevents lock detection; the invitation expires and the leader times out waiting for the member.
Keep invitation acceptance active during preparation and ensure invitation overlays cannot leave lock checking in an endless loop.
Also at `tasks/EternitySea/script_task.py:44`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tasks/EternitySea/script_task.py:183
| # self.ui_goto(page_soul_zones) | ||
| # self.orochi_enter() | ||
| # self.check_lock(self.config.orochi.general_battle_config.lock_team_enable) | ||
| self._prepare_eternity_sea() |
There was a problem hiding this comment.
🟡 中 · 准备期间邀请会过期
队长在队员准备期间发送邀请时（包括邀请弹窗遮挡锁定指示器的情况），run_member() 会等待 _prepare_eternity_sea() 返回后才调用 check_then_accept()；而当弹窗阻碍锁定状态检测时，check_lock() 可能会持续循环。结果是邀请过期，队长等待队员时最终超时。
请确保准备期间仍会接受邀请，并避免邀请弹窗导致锁定检查陷入无限循环。
另请检查 tasks/EternitySea/script_task.py:44。
给 AI 代理的提示
在 `tasks/EternitySea/script_task.py` 第 183 行：
**准备期间邀请会过期**
队长在队员准备期间发送邀请时（包括邀请弹窗遮挡锁定指示器的情况），`run_member()` 会等待 `_prepare_eternity_sea()` 返回后才调用 `check_then_accept()`；而当弹窗阻碍锁定状态检测时，`check_lock()` 可能会持续循环。结果是邀请过期，队长等待队员时最终超时。
请确保准备期间仍会接受邀请，并避免邀请弹窗导致锁定检查陷入无限循环。
另请检查 `tasks/EternitySea/script_task.py:44`。Original comment in English
🟡 Medium · Invitations expire during preparation
When the leader sends an invitation while the member is preparing, including while an invitation overlay hides the lock indicator, run_member() waits for _prepare_eternity_sea() to return before calling check_then_accept(), and check_lock() can keep looping when the overlay prevents lock detection; the invitation expires and the leader times out waiting for the member.
Keep invitation acceptance active during preparation and ensure invitation overlays cannot leave lock checking in an endless loop.
Also at tasks/EternitySea/script_task.py:44.
Prompt for AI agents
In `tasks/EternitySea/script_task.py` at line 183:
**Invitations expire during preparation**
When the leader sends an invitation while the member is preparing, including while an invitation overlay hides the lock indicator, `run_member()` waits for `_prepare_eternity_sea()` to return before calling `check_then_accept()`, and `check_lock()` can keep looping when the overlay prevents lock detection; the invitation expires and the leader times out waiting for the member.
Keep invitation acceptance active during preparation and ensure invitation overlays cannot leave lock checking in an endless loop.
Also at `tasks/EternitySea/script_task.py:44`.
Findings
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
问题
原来的代码在队员启用锁定阵容时，没有在等待邀请前检查永生之海的锁定状态，进入房间后经常出现队员不能有效锁定阵容的情况。
改动
_prepare_eternity_sea()。未运行测试。
Sourcery 总结
统一永生之海队长与队员的准备流程，确保队员在接受邀请前完成锁定阵容检查。
Bug 修复：
功能增强：
Original summary in English
Summary by Sourcery
统一永生之海队长与队员的准备流程，确保队员在接受邀请前完成锁定阵容检查。
Bug Fixes:
Enhancements: