Skip to content

fix(contexts): look up an iframe's parent among pages and iframes only (#640) #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
route merged 3 commits into from
Oct 12, 2026
Merged

fix(contexts): look up an iframe's parent among pages and iframes only (#640) #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc6ca1
fix(contexts): look up an iframe's parent among pages and iframes onl…
route Oct 5, 2026
aea4d57
test(contexts): drop the site isolation spec for #640
route Oct 12, 2026
c4991de
docs(changelog): mention the PDF viewer trigger for #640
route Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
the browser; a failed `IO.close` is raised to the caller.

### Fixed
- An out-of-process iframe, e.g. Chrome's PDF viewer for an embedded PDF, appearing while a web worker was connected
raised `'Page.enable' wasn't found` in the event thread. Only pages and iframes are now searched for its parent [#640]
- A browser context whose `Target.disposeBrowserContext` timed out stayed registered, so every later `#reset` asked
again and raised `Disposal of browser context ... is already pending` for the rest of the process. It's now
forgotten either way, and `#reset` disposes the remaining contexts before raising the first error [#641]
Expand Down
9 changes: 7 additions & 2 deletions lib/ferrum/contexts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,7 @@ def subscribe_target_created
context_id = info["browserContextId"]
add_context(context_id)

if info["type"] == "iframe" &&
(target = @contexts[context_id]&.find_target { |t| t.connected? && t.page.frame_by(id: info["targetId"]) })
if info["type"] == "iframe" && (target = find_frame_owner(context_id, info["targetId"]))
@contexts[context_id]&.add_target(session_id: target.session_id, params: info)
else
@contexts[context_id]&.add_target(params: info)
Expand All @@ -205,6 +204,12 @@ def subscribe_target_created
end
end

def find_frame_owner(context_id, frame_id)
@contexts[context_id]&.find_target do |target|
(target.page? || target.iframe?) && target.connected? && target.page.frame_by(id: frame_id)
end
end

def rearm_auto_attach(session_id, type)
return unless RECURSIVE_AUTO_ATTACH_TYPES.include?(type)

Expand Down
2 changes: 2 additions & 0 deletions sig/ferrum/contexts.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ module Ferrum

def subscribe_target_created: () -> void

def find_frame_owner: (String? context_id, String frame_id) -> Target?

def rearm_auto_attach: (String session_id, String type) -> void

def handle_attach: (Target? target, String session_id, Hash[String, untyped] params) -> void
Expand Down
Loading