send_keys: skip click if Node has focus

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Changed
 
+- Change `Node#send_keys` to avoid triggering `click` on an already focused element [#327]
+
 ### Fixed
 
 ### Removed

lib/capybara/cuprite/javascripts/index.js

@@ -523,6 +523,10 @@ class Cuprite {
     window.getSelection().deleteFromDocument();
   }
 
+  hasFocus(node) {
+    return document.activeElement === node;
+  }
+
   containsSelection(node) {
     let selectedNode = document.getSelection().focusNode;
 

lib/capybara/cuprite/page.rb

@@ -66,7 +66,7 @@ def hover(node)
       end
 
       def send_keys(node, keys)
-        unless evaluate_on(node: node, expression: %(_cuprite.containsSelection(this)))
+        unless evaluate_on(node: node, expression: %(_cuprite.containsSelection(this) || _cuprite.hasFocus(this)))
           before_click(node, "click")
           node.click(mode: :left, keys: keys)
         end

spec/features/driver_spec.rb

@@ -1331,13 +1331,17 @@ def create_screenshot(file, *args)
 
         it "sends keys to the active_element" do
           @session.find_field("empty_input").execute_script("this.focus()")
+          @session.find_field("empty_input").execute_script <<~JS
+            this.addEventListener("click", () => window.clickedBeforeFocus = true)
+          JS
 
           expect(@session).to have_field("empty_input", focused: true)
 
           @session.send_keys(:tab)
 
           expect(@session).to have_field("empty_input", focused: false)
             .and(have_field("filled_input", focused: true))
+          expect(@session.evaluate_script("window.clickedBeforeFocus")).to be_nil
         end
 
         it "sends keys to filled contenteditable div" do