Repository navigation
Skip Class#initialize test on Ruby 4.1+ - #3236
Merged
Merged
Conversation
Class#initialize was removed and Class.allocate now raises TypeError in ruby/ruby@0adee86. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ksss
changed the title
ksss
force-pushed
the
fix-class-initialize-test-ruby-head
branch
from
October 15, 2026 02:44
5bdae0c to
4d2062b
Compare
ksss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassInstanceTest#test_initializefails on ruby-head withTypeError: allocator undefined for Class.ruby/ruby@0adee86 ("Prevent uninitialized classes from being allocated") made
Class.allocateraiseTypeErrorand removedClass#initializeentirely (class creation moved intoClass.new). ruby/ruby skips this test intool/rbs_skip_tests, and ruby/spec guards the corresponding specs withruby_version_is ""..."4.1".This PR runs the test only on Ruby < 4.1 via
if_ruby(..."4.1").core/class.rbsis unchanged since it still describes the current stable Ruby (4.0). Updating the signature for 4.1 (movingClass#initializetoClass.new) needs a DefinitionBuilder change as well, so it is left for a separate discussion.🤖 Generated with Claude Code