Repository navigation
Stop creating symbol tokens in RuleBuilder - #836
Merged
Merged
Conversation
Represent symbol names and lexical kinds in Grammar::Symbol::Id. Use these values for grammar symbols, type declarations, and unresolved rule sides. Keep source locations separately for rule references and nonterminal definitions so errors still point to the input. Validate character literals in the lexer and reject unsupported symbol token types when converting to IDs.
Represent generated parameterized and midrule action symbols with Grammar::Symbol::Id. Keep source locations and LHS aliases separately so rule construction and reference resolution retain their behavior.
Update parser spec expectations to construct symbol IDs directly and remove the token-to-ID conversion from the matcher.
Move the duplicate symbol_id helper from individual specs into RSpecHelper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.