Skip to content

Remove unused GRID, LaunchDarkly, and legacy command code - #575

Open
jrhoads wants to merge 1 commit into
devfrom
quickwin/delete-dead-code
Open

Remove unused GRID, LaunchDarkly, and legacy command code#575
jrhoads wants to merge 1 commit into
devfrom
quickwin/delete-dead-code

Conversation

@jrhoads

@jrhoads jrhoads commented Sep 25, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • Delete unused GRID conversion management commands (legacy*.py).
  • Remove the GRID / LEGACY_ROR_DUMP settings block plus GRID_REMOVED_IDS and LAUNCH_DARKLY_KEY.
  • Drop the always-empty GRID_REMOVED_IDS check in retrieve_organization.
  • Delete unused rorapi/common/features.py (LaunchDarkly call site) and rorapi/v2/tests.py (redundant with unit client tests).
  • Remove the duplicate CountryBucket class from rorapi/v2/models.py (keep the shared one in rorapi/common/models.py).
  • Trim the README GRID section so it no longer documents the removed commands.

Does not change rorapi/middleware/ or the single CommonMiddleware entry.

Test plan

  • CI unit tests pass (rorapi.tests.tests_unit)
  • python manage.py check succeeds in CI
  • ruff job may soft-fail (expected until Wave 5)
Open in Web Open in Cursor 

@cursoragent @jrhoads
Remove unused GRID, LaunchDarkly, and legacy command code
bd67482 
Drop the unused GRID/LEGACY_ROR_DUMP settings, LaunchDarkly features
module, empty GRID_REMOVED_IDS lookup, duplicate CountryBucket, unused
v2 Client tests, and the legacy GRID management commands.

Co-authored-by: Joseph Rhoads <jrhoads@users.noreply.github.com>
@jrhoads jrhoads added the quickwin:wave-2 label Sep 25, 2026 — with Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

quickwin:wave-2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrhoads @cursoragent