Conversation
cursor
Bot
force-pushed
the
quickwin/index-helpers
branch
from
September 25, 2026 14:33
323cdce to
b4fdeac
Compare
Move affiliation-match / names-ids builders and the bulk-with-backup loop into rorapi.common.index_helpers so both management commands share one implementation. Leave a single _bulk hook for composing with the retry wrapper from reindex-resilience (#559) without duplicating es_bulk.py. Co-authored-by: Joseph Rhoads <jrhoads@users.noreply.github.com>
cursor
Bot
force-pushed
the
quickwin/index-helpers
branch
from
September 25, 2026 14:39
b4fdeac to
33f7601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_affiliation_match_doc, names/ids builders, and the shared bulk-with-backup loop fromindexror/indexrordumpintororapi.common.index_helpers._bulk/ injectablebulk=hook so Add retry logic and improve backup and rollback for Elasticsearch indexing #559’sbulk_with_retrycan plug in later without inventing a paralleles_bulk.py.Does not overlap the resiliency work in #559 (retry + setup backup); that PR leaves these helpers duplicated.
Test plan
tests_uniton this PRmanage.py test rorapi.tests.tests_unit.tests_index_helpers(7 tests OK)