[textinput] advance cursor when typing in overwrite mode

[ferdymercury]

This Pull request:

Changes or fixes:

as in bash. fyi @amadio

Fixes #21457

Checklist:

• tested changes locally
• updated the docs (if necessary)

[github-actions]

Test Results

    23 files      23 suites   3d 21h 28m 36s ⏱️
 3 879 tests  3 878 ✅ 0 💤 1 ❌
79 904 runs  79 900 ✅ 2 💤 2 ❌

For more details on these failures, see this check.

Results for commit c5c15ec.

♻️ This comment has been updated with latest results.

[dpiparo]

Thanks for this change!! I am not sure it's possible to do at all, and the PR could be merged as is, but have you thought about a way to test this, in order not to encounter the problem ever again?

[ferdymercury]

but have you thought about a way to test this, in order not to encounter the problem ever again?

This should do it, but I do not know if this is cross platform (not gonna work for Windows?) nor where it should go within the roottests.

echo -e "ab\033[D\033[D\033[2~.q\n" | root -b -l
// Simulates writing ab, two left-arrow presses, Ins press, and then writing .q

Before:

input_line_9:2:3: error: use of undeclared identifier 'qb'
 (qb)
  ^~
Error in <HandleInterpreterException>: Error evaluating expression (qb)
Execution of your code was aborted.

After: ROOT exits fine without errors.

[dpiparo]

Very nice. What about re-casting this in roottest?

diff --git a/roottest/root/rint/21457_input.txt b/roottest/root/rint/21457_input.txt
new file mode 100644
index 00000000000..af6c96d89ed
--- /dev/null
+++ b/roottest/root/rint/21457_input.txt
@@ -0,0 +1,4 @@
+ab
+\033[D\033[D\033[2~
+.q
+
diff --git a/roottest/root/rint/CMakeLists.txt b/roottest/root/rint/CMakeLists.txt
index 2e8e85aa471..5e5c80ed27a 100644
--- a/roottest/root/rint/CMakeLists.txt
+++ b/roottest/root/rint/CMakeLists.txt
@@ -54,3 +54,9 @@ ROOTTEST_ADD_TEST(missingSymbol
 ROOTTEST_ADD_TEST(macroCalledMain
                   COPY_TO_BUILDDIR main.cpp
                   MACRO main.cpp)
+
+# issue 21457
+ROOTTEST_ADD_TEST(inskey
+                  COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/driveTabCom.py
+                  INPUT 21457_input.txt
+                  FAILREGEX "Execution of your code was aborted.")

[ferdymercury]

What about re-casting this in roottest?

sounds good! added

[dpiparo]

I stopped the run, there is a piece missing.

got exit code 124 but expected 0

I think it's fair to expect it

[ferdymercury]

It seems it hangs there since the test takes 270.01 sec to run
so it's somehow not understanding the InsKey input encoding and sends just each character one by one?
But then not sure why it's not spitting out an error.
Maybe an issue with the python driver script?

[dpiparo]

It could be. On my local system it worked though. Let me check once again this PR locally.

[dpiparo]

my apologies. The input txt file should look like

ab\033[D\033[D\033[2~
.q

That mimics what we are trying to achieve. If not, I confirm the previous proposal leads to a timeout. Apologies for the mistake.

[dpiparo]

Last stretch: the test ought to be excluded from the battery for Windows...

[dpiparo]

Thanks and sorry for the pickiness

[dpiparo]

/backport to 6.40

[root-project-bot]

Preparing to backport PR #23328 to branch 6.40 requested by dpiparo

[root-project-bot]

Something went wrong with the creation of the PR to backport to 6.40: @dpiparo please see the logs