[misc] do not rely on obsolete Riostream.h header and deprecate - #23286
Open
ferdymercury wants to merge 5 commits into
Open
[misc] do not rely on obsolete Riostream.h header and deprecate#23286ferdymercury wants to merge 5 commits into
ferdymercury wants to merge 5 commits into
Conversation
ferdymercury
added
the
skip code analysis
ferdymercury
commented
Sep 7, 2026
ferdymercury
marked this pull request as ready for review
September 7, 2026 16:24
ferdymercury
requested review from
agheata,
bellenot,
dpiparo,
guitargeek,
hageboeck,
jblomer,
linev,
lmoneta,
pcanal and
vepadulano
as code owners
September 7, 2026 16:24
Contributor
|
Squash-on-merge would be okay here? |
Collaborator
Author
For me, always! :) |
Test Results 21 files 21 suites 3d 6h 25m 56s ⏱️ For more details on these failures, see this check. Results for commit 7fdcacf. ♻️ This comment has been updated with latest results. |
Contributor
|
@ferdymercury could you rebase to retrigger the CI? I think the failures are all unrelated but given the many touched files I would still prefer to see more green. |
ferdymercury
force-pushed
the
riostrmisc
branch
from
September 8, 2026 21:12
1657897 to
63437a2
Compare
Collaborator
Author
sure, done! |
ferdymercury
force-pushed
the
riostrmisc
branch
from
September 10, 2026 15:35
63437a2 to
c65d5ea
Compare
ferdymercury
changed the title
ferdymercury
force-pushed
the
riostrmisc
branch
from
September 10, 2026 17:26
c65d5ea to
9699181
Compare
ferdymercury
force-pushed
the
riostrmisc
branch
3 times, most recently
from
September 11, 2026 13:31
f77b310 to
2c08d4a
Compare
[io] fix header syntax [geom] missing fw declare
ferdymercury
force-pushed
the
riostrmisc
branch
from
September 11, 2026 14:39
2c08d4a to
7fdcacf
Compare
Collaborator
Author
|
@guitargeek I see some UTF8 errors in the CI, could it be related to the recent textinput upgrade? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Riostream.h header was there 25 years ago then iostream was not yet in the standards.
Use now standard headers, cleaner and more understandable, plus more fine-grained, why should one include three headers when it can just include the needed one.