[ntupleutil] add RNTupleInspector::GetPagesPerClusterDistribution - #23244
Open
silverweed wants to merge 2 commits into
Open
[ntupleutil] add RNTupleInspector::GetPagesPerClusterDistribution#23244silverweed wants to merge 2 commits into
silverweed wants to merge 2 commits into
Conversation
silverweed
force-pushed
the
ntuple_inspector_page_histo
branch
from
September 3, 2026 12:45
4d32901 to
c8ff26b
Compare
jblomer
reviewed
Sep 3, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Very nice!
I think what we (also) want to see though is the "ungrouped" distribution of pages per cluster, so I would expect to fill the histogram for every column and cluster, not for every column type and cluster.
Test Results 23 files 23 suites 3d 20h 18m 12s ⏱️ Results for commit 363ba67. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_inspector_page_histo
branch
2 times, most recently
from
September 9, 2026 12:51
a55d658 to
f783083
Compare
silverweed
force-pushed
the
ntuple_inspector_page_histo
branch
from
September 11, 2026 08:22
f783083 to
9d4efbc
Compare
silverweed
force-pushed
the
ntuple_inspector_page_histo
branch
from
September 11, 2026 14:09
9d4efbc to
363ba67
Compare
silverweed
marked this pull request as ready for review
September 11, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a method to create a histogram of number of pages per cluster in an RNTuple. Entries are aggregated in this way:
Example output:
