[NFC][core] group core subdirectories by topic - #21568
Open
ferdymercury wants to merge 2 commits into
Open
Conversation
ferdymercury
added
clean build
Test Results 21 files 21 suites 3d 10h 19m 37s ⏱️ For more details on these failures, see this check. Results for commit fddb5e4. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
March 12, 2026 07:52
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
March 12, 2026 07:52
ferdymercury
added
the
skip code analysis
couet
removed their request for review
September 1, 2026 09:03
ferdymercury
marked this pull request as draft
September 5, 2026 20:57
[cmake] add one more depth level in linkdef search To avoid compilation error with modules=OFF or windows of the type: In file included from .\etc\dictpch\allLinkDefs.h:86: .\etc\dictpch\core\base\inc\LinkDef.h:8:10: fatal error: '../../os/winnt/inc/LinkDef.h' file not found
ferdymercury
force-pushed
the
coreorg
branch
from
September 11, 2026 13:08
1bf88e2 to
fddb5e4
Compare
ferdymercury
marked this pull request as ready for review
September 11, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just exploring if such a logic reorganization is doable.
Right now, core is cluttered with many alphabetically sorted subdirs, grouping them by topic/function could help in having better graphical overview.
core/os now groups unix, macos, winnt
core/parallel now groups imt, multiproc, thread