Repository navigation
[ci] Land #98 on main (harden the CI workflows) - #100
Merged
Merged
Conversation
Every job sets timeout-minutes (about 3-5x its slowest observed run). evals.yml, kit.yml and notify-plugins.yml set permissions: contents: read; none writes with GITHUB_TOKEN. deploy.yml's staging and production jobs, which run on tags and releases and ship what they build, no longer restore the pnpm cache, and the production version step reads release.tag_name through env instead of splicing it into the script. ci.yml's gitleaks download runs under bash with pipefail and curl -f, and checks the tarball's SHA-256 before extracting. evals.yml quotes the suite filter, notify-plugins.yml queues instead of overlapping, kit.yml drops an unused job output, and its rename job's unfrozen install, which the rename's package-name rewrite requires, is marked as intended. jactionlint --online now reports no findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pin-actions entry said setup-node keeps cache: pnpm, which the hardening entry below it then removes from the two deploy jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This lands #98 on
main. #98 was merged into its stacked baseci/pin-actionsrather thanmain, because that base wasn't deleted on merge. The workflow changes are #98's commitb6ec628, cherry-picked unchanged:The only other changes are:
cache: pnpm, which the review gate flagged as contradicting the hardening entry.main: it changes no files, and means the branch isn't behindmain.Evidence
jactionlint --onlinereports 0 findings, andactionlintis clean.pnpm gatepasses on Node 26.13.0. Mergingmainleaves the tree identical to the gated one.Merge Danger
Door: two-way
Blast Radius: CI
The changes that can affect a run are the timeouts and the uncached deploy installs. Merge with a merge commit.
🤖 Generated with Claude Code