Repository navigation
analytics: scope the dashboard-visibility setup delete by tenant - #9
Merged
Merged
Conversation
The kit's unscoped-allowlist scan walks every tracked file under src/, plugin tests included, and flagged the delete by pageId alone. Fixes #8. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
dashboard-visibility.test.tsremoves a page's last group grant withand(eq(tenantId), eq(pageId)), where it used to match onpageIdalone. The kit'sunscoped-allowlistscan now passes with no allow-list entry. This is the issue's option 2.unreleased.md. It includes a step to delete any temporaryCORE_UNSCOPED_ALLOWLISTentry an app added.Why CI missed it: the kit's scanners read
git ls-files, and plugin CI never staged the installed plugin, so plugin files were never scanned. That is fixed in rocketflare-dev/rocketflare#39 (plugin-ci.ymlrunsgit add -Aafter the install). In a scratch kit clone with all four plugins installed and staged, the scan flagged the unfixed 3.4.1 file and passed with this change. Every other config scanner also passed for all four plugins. The only failures were plugin-check's "no migration" errors, because I didn't rundb:generatethere.The fix reaches apps only after a release (3.4.2).
🤖 Generated with Claude Code