Move hard-coded networks to yml files. - #1198
Open
0xfornax wants to merge 1 commit into
Open
Conversation
0xfornax
force-pushed
the
refactor-networks-yml
branch
from
August 27, 2026 19:39
2544ede to
f6e70f6
Compare
Merging this branch changes the coverage (6 decrease, 7 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
0xfornax
marked this pull request as ready for review
August 28, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load Ethereum networks from YAML instead of hard-coding them.
Smart Node network identity and behavior now come from networks-default.yml, loaded at startup.
Official networks (mainnet, Hoodi testnet, kurtosis devnet) live in shared/services/rocketpool/assets/install/networks-default.yml. rocketpool service install always overwrites ~/.rocketpool/networks-default.yml with that file.
Operator overlay: optional ~/.rocketpool/networks-extra.yml. Same-name entries replace official ones; new names are appended and show up in service config. Extra networks may omit Rocket Pool contract addresses so clients can sync on a chain that has no RP deployment.
Also
Closes #438