Repository navigation
fix(ci): fail the release when a publish step fails - #2
Merged
Merged
Conversation
The two publish steps were not checked for a non-zero exit code. A native command that fails does not abort a pwsh script, so a failed first publish followed by a successful second one ended the step green, and the release went out without the self-contained build. The updater only accepts the self-contained build, so that release is one no installed app could ever update from, and nothing in the pipeline says so. The missing asset is something a person has to notice by hand. The check is the same one 033-windowshuttle already has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two publish steps were not checked for a non-zero exit code. A native command that fails does not abort a pwsh script, so a failed first publish followed by a successful second one ended the step green, and the release went out without the self-contained build.
The updater only accepts the self-contained build, so that release is one no installed app could ever update from, and nothing in the pipeline says so.
The check is the same one
033-windowshuttlealready has.