Repository navigation
Match SPSCQueue false-sharing ranges - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match SPSCQueue's false-sharing ranges for queue counters and slots.
The 128-byte spacing puts neighboring hot locations in separate aligned
pairs for CPUs with adjacent-cache-line prefetching.
Evidence
intslot occupied 64 bytes and had 64-byte alignment.Clang Release passed
MPMCQueueTest. The rebased release stack also passedASan/UBSan, GCC 14 MC/DC, and GenMC. Throughput is still unmeasured.
Merge Danger
Door Two-way. Reverting restores the previous spacing.
Blast radius Consumers on the affected architectures must rebuild
together because the queue layout changes. Small-element queues use more
memory per slot.