Repository navigation
Modernize queue constraints, storage, and alignment for C++20 - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second PR in the MPMCQueue 2.0 stack.
Reuse the
try_consumeslot handoff intry_pop. Enqueue construction,dequeue assignment, and the consume callback still need to be non-throwing.
Evidence
dequeue could select a deleted move assignment despite a valid copy assignment.
MPMCQueueTest, includingcopy-only over-aligned elements, move-only elements, and
try_consume.Merge Danger
Door Two-way. Reverting restores the previous header implementation.
Blast radius Header consumers should rebuild together when upgrading
because the queue and slot layout may change. Ignored try-operation results
can now trigger
[[nodiscard]]diagnostics.