Shows the drafts tray in the reference embedder - #44
Merged
Conversation
Pins statifier_blocks to the drafts-shelf commit on its main (a3833479, PR 201) - INTERIM, per the se-p22 pattern: 0.11.0 is the published floor and carries neither core.drafts nor core.placeholder. mix_deps_test guards the ref in mix.exs and mix.lock together, as it does for the other two pins. The uptake itself needed no wiring. Palette.from_modules/2 with core: true carries both new types, the package stylesheet this app already imports carries .sb-slot--tray, and "inbox" is a name the host's heroicon set resolves. What the app adds is a document that asks for the surface: card_processing_sketch, the payment flow caught mid-authoring, with the tail parked in a core.drafts shelf and a core.placeholder standing where the middle will go. Adds the sink-backwards beat on it - demo-script.md section 13, and a LiveView test that drives the same sequence through the editor's own drag, remove and drop events: park the tail, build the sources, place the tail, and watch the header fall from Findings 2 to Findings 0. Refs: se-ihm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drafts tray, visible in the reference embedder, and the beat it exists
for: a flow authored backwards from its sink.
The interim pin
statifier_blocksmoves from Hex~> 0.11to a git ref on that repo'smain,
a3833479257fb0692eea65ed50c00c939b489f36- the merge of its PR 201,the first commit carrying
core.drafts,core.placeholder,StatifierBlocks.Shelfand the.sb-slot--traystrip. 0.11.0 carries noneof them, so the fixture below would name two types no palette resolves.
This is INTERIM, on the established
se-p22pattern. FINAL re-pinafter the operator publishes statifier_blocks 0.12.0: back to
{:statifier_blocks, "~> 0.12"}, retiring@statifier_blocks_refand itsguard with it. Tracked by
se-l9s's third half, alongside the openstatifierandstatifier_persistencehalves.mix.lockmoved by exactly that one entry.test/statifier_examples/ mix_deps_test.exsguards it the way the other two pins are guarded: one@statifier_blocks_refasserted against bothmix.exsandmix.lock, soan edit to one without the other cannot pass.
The uptake needed no wiring, and that is the finding
Nothing in
lib/statifier_examples_web/**changed. The two new types reachthis app's editor on their own:
StatifierExamples.Charts.palette/0builds withPalette.from_modules(registrations(), core: true), andcore_types/0is now 15 rather than 13, so the palette is 28 entries rather than 26;
assets/css/app.cssalready imports the package stylesheet by path, and.sb-slot--trayis in it - no new--sb-*token, so no host themechange;
core.draftsdeclares the icon"inbox", and this app resolves iconnames against the whole heroicons
24/outlineset rather than ahand-written subset, so the tile draws.
For a package whose uptake bead expected palette registration and CSS
passthrough, that is worth recording as the reference embedder's answer:
the surface arrived and the host had nothing to do.
What the app does add
priv/fixtures/card_processing_sketch.json(bdoc_cp_sketch, keycard_processing_sketch) - the same payment flow ascard_processing,caught halfway through being authored. The tail the author already knows,
a
Sequenceof Build the receipt and Send the receipt, is parkedin a
core.draftsshelf at the root'sbody; acore.placeholderstandswhere the middle will go; a
core.assignseedscapture.attempts; and thedatamodeldeclaresamountandauthorizationahead of the steps thatwill use them, which is what authoring from the sink backwards looks like
in the document. It opens at
Findings 2- a shelf with anything in it anda placeholder each raise an author warning on a compile that succeeds.
docs/demo-script.mdgains section 13, the sink-backwards beat, and itsone falsified row is corrected (beat 1's palette count, 26 -> 28).
StatifierExamplesWeb.EditorLiveTestgains the beat's machine-verifiedhalf: three rows that mount the sketch, assert the tray draws with the tail
in it, and then drive the whole sequence through the editor's own
insert-dragstart/insert-drop/remove/dragstart/dropevents - park the tail, build the sources, place the tail - ending with an
empty tray, the tail in the flow, and the header at
Findings 0. That zerois the publish gate read off the page: what a host does about parked work
is host policy off
%Compiled{}.warnings, and this is that policy walked.Four sibling assertions the new fixture falsifies are updated in place: the
fixture list in
charts_test, the registration row incard_auth_test,the per-fixture label counts in
step_label_test, and the declared-rootslist in
fixture_datamodel_test.Evidence
Live on a private port (8651) on this branch, through the promoted DevTools
driver - the frozen demo ports were not touched:
se-ihm-light-tray.png,se-ihm-dark-tray.png,se-ihm-brand-tray.png-the tray at the foot of the canvas with the tail parked in it, in all
three themes;
se-ihm-light-tray-drag.png- a palette entry dragged over the tray,driven by
DragEvents carrying aDataTransferfrom page JS(
se-ihm-drag.js); the tray stampsdata-drop="ok", which ispalette-to-tray drop being permitted by the declaration rather than by
new machinery;
se-ihm-light-tray-placed.png- the settled end state after the samesequence the test drives, run in a real browser (
se-ihm-beat.js):Findings 2->Findings 0,8 blocks/depth 4->9 blocks/depth 3, tray empty.Every mutation was run by hand and shown red before being reverted from a
backup copy: the shelf retyped to
core.sequence, the shelf's bodyemptied, the pin ref pointed at the previous
statifier_blocksmain487cebf1, and the sketch dropped from@documents.Full
mix qualitygreen on the branch: 243 tests, 77.5% coverage, dialyzerclean.
Provenance
se-ihm(campaign 024, Lane A uptake A3).statifier_blocksPR 201 (sb-uag7), whose closing notes arethe facts this uptake is written against.
direct child of the root's
body, at most one per document) as aconsumer of it; the rule itself is enforced upstream.
docs/adr/path in this diff, so no direction-agent review gateapplies.
mainat5bafc2f2and no 024 sibling has touched these files.