fix: Preserve explicit zero timedelta values in discovery manifests - #230
Open
hnicke wants to merge 1 commit into
Open
fix: Preserve explicit zero timedelta values in discovery manifests#230hnicke wants to merge 1 commit into
hnicke wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Setting retention times to `timedelta(seconds=0)` was silently dropped; instead, the global defaults were used. Now, settings the retention times to 0s properly disables the rentention.
hnicke
force-pushed
the
fix-zero-retention
branch
from
August 29, 2026 08:09
e4b6aa6 to
46016d1
Compare
hnicke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing explicit
timedelta(seconds=0)timedelta values for inactivity timeout, abort timeout, journal retention and idempotency retention was silently dropped - instead, the global defaults were used.Now, settings the retention times to
0sproperly disables the rentention.Fixes #172