Repository navigation
fix: keep --status in the next-page hint of filtered lists - #412
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
contacts imports list and automations runs list accept a --status filter, but their next-page hint dropped it. Running the suggested command returned the next page of the unfiltered list, starting from a cursor taken from the filtered one. Pass the filter through extraFlags, as suppressions list does for --origin.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resend contacts imports listandresend automations runs listaccept a--statusfilter, but the "Fetch the next page" hint they print drops it. Running the suggested command returns the next page of the unfiltered list, starting from a cursor taken from the filtered one.This change passes the filter through
extraFlags, the same waysuppressions listkeeps--originandbroadcasts recipientskeeps its filters. The hint now ends in--status failed.Testing
--statusfor both commands. They fail onmain(2 failed, 6 passed) and pass with the change (8 passed).tests/commands/automations/runs/list.test.tsis new, sinceautomations runs listhad no tests.pnpm test: 141 files, 1170 passed, 1 skipped.pnpm lintandpnpm typecheckare clean.Summary by cubic
Fixes the "Fetch the next page" hint in
contacts imports listandautomations runs listso it keeps the--statusfilter the user set. Previously, running the suggested command returned the next page of the unfiltered list, even though the cursor came from a filtered result. The hint now ends with the--statusvalue, matching howsuppressions listhandles--origin. Adds tests for both commands, including a new test file forautomations runs list.Written for commit 5a1b5f8. Summary will update on new commits.