Repository navigation
Pin pocket-kit v0.4.0: replays expire after 7 days, viewer local-only - #381
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pocket_kit pin from v0.3.0 to v0.4.0 (https://github.com/calebl/pocket-kit/releases/tag/v0.4.0). Stored session replays now expire after pocket-kit's default 7 days, and the replay viewer answers only this machine. Both defaults are what we want, so no setting changes. The initializer comment and README now say so. Typed text stays masked and error reporting is unchanged.
Tests: full
bin/rails testpasses (5503 runs, 0 failures), rubocop is clean. No post-update step needed.