Repository navigation
Retain available snapshots independently of failed captures - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed captures currently consume the same retention slots as available snapshots, so an interleaved failure can cause the previous usable snapshot to be pruned. Retain the newest
keepavailable snapshots and remove matching failed captures separately.Preserve group/name isolation, pagination, creating snapshots, idempotent deletion, and warning-only pruning failures. The regression reproduced deletion of the previous usable version before the fix; tests now cover interleaved failures, success-count boundaries, pagination, protected entries, and both typed and generic 404 responses.
Validation: focused tests 27 passed; independently rerun typecheck/full suite 88 passed with 1 live-model test skipped; frozen install and diff checks passed. Dependencies are unchanged.
The policy applies on the next successful refresh after deployment. No real provider restore failure or cloud deployment was exercised.
Fixes #27.