Fix query indexing at the cache boundary - #869
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
get_item(1)could raiseIndexErrorwhile more results exist.Implementation
Note
Low Risk
Small bounds-check change in query indexing with targeted tests; behavior fix for partial caches, no auth or data-model changes.
Overview
Fixes off-by-one cache hits when indexing a
FindQuerythat only has a partial result set loaded (e.g. afterexecute(exhaust_results=False)).Both sync
__getitem__and asyncget_itemnow treat the cache as usable only whenlen(_model_cache) > iteminstead of>= item. With a single cached row, index1no longer reads past the cache and raisesIndexError; it clones the query withoffset=1, limit=1and fetches the next document.Adds
tests/test_find_query_cache.pyto cover cached vs uncached indexes and out-of-range access for asyncget_itemand sync[].Reviewed by Cursor Bugbot for commit 2e2d779. Bugbot is set up for automated code reviews on this repo. Configure here.