Conversation
There was a problem hiding this comment.
Great change! It just needs some polish to fix three issues with the new circle icons:
-
When clicking on phone or emulator it only selects the item, therefore necessitating two presses to change account. This should be changed to only one press to match the rest of the app. This happens because you use
focusableInTouchMode="true". -
focusableandclickableare dynamically set whenever you add focus or click listeners, they should not be defined in the XML. This is to prevent issues in the future. -
Whenever you focus an item on a phone emulator (using arrow keys) it also creates a white transparent square box as opposed to just the white circle outline.
Thanks for the review! Since I was only testing on emulator and TV interface, I made some mistakes. With my latest commit i tried to fix those issues. I also tried to add light theme compatibility. |
This PR makes account profile avatars rounded for better visual appeal. It also fixes the invisible dpad focus on the profile edit button in TV mode.
I took advice from a user's suggestion on discord;

Before:
After: