Skip to content

Feat: Rounded profile avatar - #3209

Open
ByAyzen wants to merge 4 commits into
recloudstream:masterfrom
ByAyzen:round-profile-avatar
Open

ByAyzen wants to merge 4 commits into
recloudstream:masterfrom
ByAyzen:round-profile-avatar

Conversation

@ByAyzen

@ByAyzen ByAyzen commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

This PR makes account profile avatars rounded for better visual appeal. It also fixes the invisible dpad focus on the profile edit button in TV mode.

I took advice from a user's suggestion on discord;
resim

Before:

resim

After:

resim

@fire-light42 fire-light42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! It just needs some polish to fix three issues with the new circle icons:

  1. When clicking on phone or emulator it only selects the item, therefore necessitating two presses to change account. This should be changed to only one press to match the rest of the app. This happens because you use focusableInTouchMode="true".

  2. focusable and clickable are dynamically set whenever you add focus or click listeners, they should not be defined in the XML. This is to prevent issues in the future.

  3. Whenever you focus an item on a phone emulator (using arrow keys) it also creates a white transparent square box as opposed to just the white circle outline.

@ByAyzen

ByAyzen commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Great change! It just needs some polish to fix three issues with the new circle icons:

1. When clicking on phone or emulator it only selects the item, therefore necessitating two presses to change account. This should be changed to only one press to match the rest of the app. This happens because you use `focusableInTouchMode="true"`.

2. `focusable` and `clickable` are dynamically set whenever you add focus or click listeners, they should not be defined in the XML. This is to prevent issues in the future.

3. Whenever you focus an item on a phone emulator (using arrow keys) it also creates a white transparent square box as opposed to just the white circle outline.

Thanks for the review! Since I was only testing on emulator and TV interface, I made some mistakes. With my latest commit i tried to fix those issues. I also tried to add light theme compatibility.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants