Update the updater to compose - #3204
Merged
Merged
Conversation
|
Hey @LagradOst, I have ported the silent background pre-download and cached install logic directly on top of your Compose updater branch and submitted a PR to your branch: LagradOst#1 Feel free to review and cherry-pick or merge into #3204 whenever convenient! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updates the updater with a new UI and logic. This is a major refactor to every part of the updater, as the old code was a bit weird tbh. It does this by adding a composeview to the main activity with a shared githubviewmodel to handle the update fetching. I cant use the githubviewmodel on cross platform (yet), but it is written to allow desktop updates by github as well.
A lot of testing is needed on this to ensure that we do not accidentally break the downloader on pre or stable.