fix(cli): expose generated list pagination controls - #22
Open
realmroot[bot] wants to merge 1 commit into
Open
realmroot[bot] wants to merge 1 commit into
realmroot[bot] wants to merge 1 commit into
Conversation
realmroot
Bot
force-pushed
the
fix/generated-list-pagination-help
branch
from
September 13, 2026 12:17
2dd737d to
44a8118
Compare
realmroot
Bot
force-pushed
the
fix/generated-list-pagination-help
branch
from
September 13, 2026 13:07
44a8118 to
4f70c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Summary
--no-paginate,--max-pages, and--max-itemsalongside per-page flags such as--page-size.--page-size/similar operation flags) from total limiting (--max-items).--rsh-*internals.runRestishflushes again.--max-pages=1warning semantics, and--max-itemstotal item limiting.AGENT_SESSION_ID, matching Codex session precedence documented ininternal/agenttests.Reviewer Journey
internal/cli/cli.goaroundoperationHelpWriter.Flush: the writer resets its buffer and only emits once, so Restish internal flush plusrunRestishpost-run flush cannot duplicate help.appendGeneratedPaginationHelp: it documents Toolbox pagination controls for generated operation help and explicitly says list operations auto-paginate when pagination links are available.internal/cli/cli_test.go:TestGeneratedOperationHelpExecutionPrintsPaginationOnceruns generatedlist-tasks --helpthrough the embedded runtime/writer wiring and asserts exactly one Usage, Flags, and Pagination section.TestEmbeddedGeneratedListPaginationUsesTranslatedProductFlags: the fixture now returns a page-envelope body (items) and configuresPagination.ItemsPath, covering first-page/no-paginate and total--max-itemsbehavior on envelope responses.Checks
go test ./internal/cli -run 'Test(ParseToolboxFlagsTranslatesPaginationControls|GeneratedListHelpDocumentsProductPaginationControls|GeneratedOperationHelpExecutionPrintsPaginationOnce|ProductVocabularyWriterRewritesPaginationWarnings|EmbeddedGeneratedListPaginationUsesTranslatedProductFlags)' -count=1 -v\n-go run . toolbox agent-kanban task list-tasks --help(exit 0; one Usage/Flags/Pagination section)\n-go test ./internal/cli\n-go build ./...\n-AGENT_SESSION_ID= go test ./...\n\nNote: plaingo test ./...in this Codex session inheritsAGENT_SESSION_IDand fails existinginternal/agentsession-isolation tests that varyCODEX_THREAD_ID; clearingAGENT_SESSION_IDmatches their intended isolated environment.\n\nBase SHA: 7964480\nHead SHA: 4f70c9c🤖 Created by Cedar via Realmroot