[1.x] Improve PHP 8.5+ support by avoiding deprecated setAccessible() calls in tests - #547
Merged
Merged
Conversation
WyriHaximus
force-pushed
the
1.x-PHP8.5
branch
from
September 8, 2026 15:12
663ff51 to
86ebd46
Compare
In PHP8.1 ReflectionProperty::setAccessible was made a no-op through https://wiki.php.net/rfc/make-reflection-setaccessible-no-op in PHP8.5 it is now throwing a deprecation warning by: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
WyriHaximus
force-pushed
the
1.x-PHP8.5
branch
from
September 8, 2026 15:16
86ebd46 to
9bfb2de
Compare
clue
approved these changes
Sep 9, 2026
clue
left a comment
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
clue
changed the title
setAccessible() calls in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP8.5 by running against PHP8.5 on CI and ensuring the code is compatible with PHP8.5.
Builds on #546, #537, and many others.