[CONTENT] ReactOS 0.4.16 press release - #144
Conversation
|
Thanks for your contribution! |
230bff0 to
077f08a
Compare
077f08a to
15dca41
Compare
| date: 2026-07-02 | ||
| tags: [ "release" ] | ||
| --- | ||
|
|
There was a problem hiding this comment.
Here we probably need to say hello to our followers first I guess:
| Hello ReactOS followers! |
or even better like this:
| Greetings ReactOS followers! |
There was a problem hiding this comment.
So, do we plan to apply this suggestion? Or it's actually not required?
There was a problem hiding this comment.
I don't think it's required
|
For reviewers: please have a look also at #138 . |
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
HBelusca
left a comment
There was a problem hiding this comment.
Here's my list of final suggestions.
Note also that there are remaining "REMOVE ME" in the text (toward the end) that need to be addressed.
| For years ReactOS has been plagued by different issues with all major video driver vendors. | ||
|
|
||
| Nvidia GPUs in particular had been plagued by a slow down issue that many talented contributors and developers investigated. | ||
| Eventually Justin Miller ([The_DarkFire_](https://github.com/darkfire01)) recognized that the kernel was running out of system page table entries (PTEs) when loading third party drivers. |
There was a problem hiding this comment.
| Eventually Justin Miller ([The_DarkFire_](https://github.com/darkfire01)) recognized that the kernel was running out of system page table entries (PTEs) when loading third party drivers. | |
| Eventually, Justin Miller ([The_DarkFire_](https://github.com/darkfire01)) recognized that the kernel was running out of system page table entries (PTEs) when loading third party drivers. |
comma after "Eventually" ?
There was a problem hiding this comment.
I don't think it's needed. I like how this reads without the comma slightly more, but it's not a big deal either way.
|
|
||
| {{< video src="/img/project-news/reactos-0416-released/hdaudbus.mp4" type="video/mp4" caption="Setting up the installation, and file copy hang">}} | ||
|
|
||
| The new HD audio bus driver depends on the Kernel Mode Driver Framework (KMDF). |
There was a problem hiding this comment.
Suggestion: mention its license
There was a problem hiding this comment.
Isn't the license MIT? In case it is, it's probably not necessarily no mention it? 🤔
There was a problem hiding this comment.
Same question regarding to the new HDAudBus driver itself.
oleg-dubinskiy
left a comment
There was a problem hiding this comment.
Still some comments to be addressed.
|
|
||
| Oleg also fixed the volume and balance sliders in Sound Properties (`mmsys.cpl`) and Audio Volume Mixer (`sndvol32.exe`). | ||
| Now the volume and balance levels are saved and restored on reboot when using an HD audio codec. | ||
| In addition, Oleg updated the audio device enumeration code to support more sound cards. |
There was a problem hiding this comment.
Ah, I've just forgot, sorry. I think it's worth to mention here my PnP and setupapi fixes required for Windows audio stack too. Also, improve an explanation of audio devices enumeration fix, about what was actually done with it. Like follows:
| In addition, Oleg updated the audio device enumeration code to support more sound cards. | |
| In addition, Oleg updated the audio device enumeration code to skip non-working audio devices, allow proceeding to the working ones, and hence to properly detect more sound cards. | |
| Also, he implemented retrieving device interface aliases from Registry in ReactOS PnP stack and fixed device interface Registry key creation in SetupApi, | |
| which allows to load audio stack (system audio drivers and user-mode components) from Windows 2000, XP and Server 2003: | |
| drmk.sys, kmixer.sys, ks.sys, portcls.sys, swenum.sys, sysaudio.sys, wdmaud.sys, wdmaud.drv and winmm.dll. | |
| However, the sound doesn't work yet with such a replacement because of other bugs. |
There was a problem hiding this comment.
Aside question: should audio replacement components list be mentioned too?
There was a problem hiding this comment.
No, that is redundant and hard to read. Meriam Webster defines enumeration as "the act or process of making or stating a list of things." If you fix the audio device enumeration code, you are fixing the list of detected audio devices; and the end result of that is that more audio devices work.
| date: 2026-07-02 | ||
| tags: [ "release" ] | ||
| --- | ||
|
|
There was a problem hiding this comment.
So, do we plan to apply this suggestion? Or it's actually not required?
|
|
||
| {{< video src="/img/project-news/reactos-0416-released/hdaudbus.mp4" type="video/mp4" caption="Setting up the installation, and file copy hang">}} | ||
|
|
||
| The new HD audio bus driver depends on the Kernel Mode Driver Framework (KMDF). |
There was a problem hiding this comment.
Isn't the license MIT? In case it is, it's probably not necessarily no mention it? 🤔
dc6256c to
593b1ec
Compare
No description provided.