Repository navigation
build(deps): bump ReactiveUI.Binding to 8.8.0 - #4530
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4530 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 175 175
Lines 6231 6231
Branches 743 743
=======================================
Hits 5838 5838
Misses 392 392
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
ReactiveUI now builds against ReactiveUI.Binding 8.8.0.
BindingVersioninDirectory.Packages.propsis now8.8.0.floatbound to text through the runtime converter formats with the invariant culture, as a generated binding does.Why
ReactiveUI.Avalonia and ReactiveUI.Uno move to ReactiveUI.Binding 8.8.0, which fixes generated bindings on Uno controls and on field controls. ReactiveUI references the same version so the platform packages do not pull it onto one it was never built against.
Breaking changes
None in ReactiveUI. ReactiveUI.Binding 8.8.0 formats a
floatwith no conversion hint in the invariant culture, so an app in a culture with a decimal comma sees7.25where it saw7,25.How this was verified
Built the whole solution and ran the test projects CI runs on Linux. The Windows-only test projects run in CI.
Notes for the reviewer
A version bump only.
Checklist