Repository navigation
build(deps): bump ReactiveUI.Binding to 8.6.0 - #4528
Merged
Merged
Conversation
ReactiveUI.Binding 8.6.0 lets an interaction be asked as an observable again: IInteraction.Handle returns IObservable<TOutput>, Interaction.WhenHandled returns the question as a cold observable, and a new constructor runs handlers on a scheduler.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4528 +/- ##
==========================================
+ Coverage 93.64% 93.69% +0.04%
==========================================
Files 175 175
Lines 6231 6231
Branches 743 743
==========================================
+ Hits 5835 5838 +3
+ Misses 395 392 -3
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
ReactiveUI now builds against ReactiveUI.Binding 8.6.0, which lets you ask an interaction as an observable again.
BindingVersioninDirectory.Packages.propsis now8.6.0.IInteraction<TInput, TOutput>.Handle(TInput)returnsIObservable<TOutput>, as it did in ReactiveUI 24.Interaction<TInput, TOutput>.WhenHandled(TInput)returns the question as a cold observable.new Interaction<TInput, TOutput>(handlerScheduler)runs each handler on that scheduler, such asRxSchedulers.MainThreadScheduler.Interaction<TInput, TOutput>.Handle(TInput)still returnsTask<TOutput>, so code written against 25.0.0 keeps compiling.Why
Moving
Interactioninto ReactiveUI.Binding changed its API by accident in 25.0.0. Code upgrading from ReactiveUI 24 that subscribed toHandle, used it in an observable chain, or passed a handler scheduler stopped compiling. ReactiveUI.Binding 8.6.0 (reactiveui/ReactiveUI.Binding.SourceGenerators#151) restores it.Breaking changes
None for code that uses or derives from
Interaction<TInput, TOutput>. A class that implementsIInteraction<TInput, TOutput>itself must implementHandle(TInput)returningIObservable<TOutput>. Nothing in this repository does.How this was verified
Every Linux-runnable core test project passes on net10.0 against the released 8.6.0 packages.
ReactiveUI.Tests(879),ReactiveUI.Tests.Reactive(881),ReactiveUI.AOT.Tests(39),ReactiveUI.Testing.Tests(57) andReactiveUI.Builder.Tests(184) pass.Checklist