Repository navigation
[5.x] Added Mage-OS to the Playwright tests - #1434
Open
claudio-ferraro wants to merge 3 commits into
Open
claudio-ferraro wants to merge 3 commits into
claudio-ferraro wants to merge 3 commits into
Conversation
Member
|
Could you check this one @claudio-ferraro, a test fails |
royduin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1871
We want the Playwright tests to run against Mage-OS as well as standard Magento, so we know everything works on both.
This adds Mage-OS 3.6.0 (
michielgerritsen/mage-os-community-edition:php85-fpm-mage-os3.6.0-sample-data) to the matrix. The Mage-OS image uses a different tag pattern, so every matrix entry now names its ownmagento-imageinstead of building it from the Magento version. The existing Magento versions are unchanged and keep the same job names. The Mage-OS job compares against the same screenshots as 2.4.9 but doesn't update them, so visual differences between the two show up as failures.Test run in my fork, all green on 2.4.8-p5, 2.4.9 and Mage-OS 3.6.0: https://github.com/claudio-ferraro/core/actions/runs/38755016520
The same change goes into core, account, checkout-theme, confira and reviews.