Repository navigation
Conversation
|
I thought this was already a v5 feature, now it's again a "breaking" thing? As it's not a Magento feature, maybe we should make this configurable? |
This is a weird one. I've been told it's part of FW, but there it's just a custom attribute in Magento, so while it's "implemented" in a v5 project, it's not actually part of the core. This was supposed to be a v5 feature but then it never got given enough priority (see: RAP-1903). Now that we've gotten to updating the project this was actually for, it turned out to never be in the core and I've had to add it. I can add a config value for this, however, to keep it fully backwards compatible. |
|
I've added a config option for this in |
royduin
left a comment
There was a problem hiding this comment.
Looking good to me, @indykoning?
ref: BORDEX-1505
#1286 but then for 5.x