Repository navigation
Fix use-after-free when generated C output cannot be written - #334
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When recursive database generation cannot open or write its generated C file,
dothec()jumps to cleanup with a danglingsb:strbuf_drain()has already freed it.strbuf_free(sb)then reads freed memory and may crash.Clear
sbimmediately after draining it. This also covers an empty drain and a short write. Add a regression case to the existing recursive CLI test by making the output C path a directory.Validation: reproduced the pre-fix heap-use-after-free with ASan at
strbuf_free()(src/strbuf.c:79), called fromdothec(). The same reproducer andtest/recursive.shpass after the fix with ASan/UBSan andUSE_MMAN=0.Found while investigating the intermittent Windows build failure in radareorg/radare2#27270. This fixes a confirmed error-path bug; it is not yet established as the cause of that particular CI failure.