font dialog: keep sample text white in dark mode - #371
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
otherjoel
added a commit
to otherjoel/camp
that referenced
this pull request
Sep 20, 2026
gui-lib's font dialog resets its sample's style on every change, which drops the white foreground text-field% sets in dark mode and leaves black on black. choose-font wraps get-font-from-user and recolors the sample text once the dialog is up. A fix is proposed upstream (racket/gui#371); this can go once a release carries it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
|
This looks reasonable to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where, in dark mode on macOS, the sample text in the
get-font-from-userdialog can't be seen. It is black text on a black field.This issue was found and patch written by Claude:
It looks like the right fix, and I can verify it works on macOS Sequioa in dark mode with Racket 9.3. But scrutinize accordingly.