feat: expose sites.json as a url - #6
Open
michal-skraburski wants to merge 2 commits into
Open
michal-skraburski wants to merge 2 commits into
michal-skraburski wants to merge 2 commits into
Conversation
Member
|
i wonder if if makes sense to add a small snippet to copy as well, which already has the logic written on how to work with the sites json file. so all you would really have to do it copy the code. <script>
// the logic...
</script>
<nav id="webring"> <!-- the html --> </nav> |
Contributor
Author
|
I'll implement a little snippet to do that, no worries! |
wiktoriavh
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per our discussion, this feature allows a participant of the webring to fetch the
sites.jsondynamically and implement their own logic. This has the following benefits:Unfortunately I was not able to put the
sites.jsoninpublic/as Vite was throwing an error saying it was not permitted/unideal to include a file served underpublic/due to bundling. I didn't fully understand this, and proceeded to offer you this equally good alternative instead. This method is still fully static.