Skip to content

Copy MINA's BogusTrustManagerFactory - #1357

Merged
chrjohn merged 2 commits into
masterfrom
copilot/vendor-mina-bogus-trust-manager
Oct 24, 2026
Merged

chrjohn merged 2 commits into
masterfrom
copilot/vendor-mina-bogus-trust-manager

Conversation

@chrjohn

@chrjohn chrjohn commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

MINA 2.2.10 will remove BogusTrustManagerFactory. To ease the migration for people who want to run MINA 2.2.10 with QFJ (by using MINA 2.2.10 at runtime) we will simply copy the factory over to QFJ.

NOTE: upgrading to MINA 2.2.10 is currently not advised when using SSL in combination with proxy. See #1348 and apache/mina#84

Summary

  • copy Apache MINA's BogusTrustManagerFactory into QuickFIX/J's SSL package
  • use the local factory when no trust store is configured, removing the dependency on MINA's removed class

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.79%. Comparing base (e6aa539) to head (4887ae7).

Files with missing lines Patch % Lines
...va/quickfix/mina/ssl/BogusTrustManagerFactory.java 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1357      +/-   ##
============================================
- Coverage     70.81%   70.79%   -0.03%     
  Complexity     2272     2272              
============================================
  Files           161      162       +1     
  Lines          9077     9087      +10     
  Branches       1192     1192              
============================================
+ Hits           6428     6433       +5     
- Misses         2197     2201       +4     
- Partials        452      453       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrjohn chrjohn changed the title Vendor MINA bogus trust manager Copy MINA's BogusTrustManagerFactory Oct 23, 2026
@chrjohn chrjohn added this to the QFJ 3.0.3 milestone Oct 23, 2026
Updated comment to reflect the correct version of Apache MINA from which the code was copied.
@chrjohn
chrjohn marked this pull request as ready for review October 23, 2026 17:14
@chrjohn
chrjohn merged commit e6d9059 into master Oct 24, 2026
12 of 14 checks passed
@chrjohn
chrjohn deleted the copilot/vendor-mina-bogus-trust-manager branch October 24, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant