Repository navigation
Copy MINA's BogusTrustManagerFactory - #1357
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
============================================
- Coverage 70.81% 70.79% -0.03%
Complexity 2272 2272
============================================
Files 161 162 +1
Lines 9077 9087 +10
Branches 1192 1192
============================================
+ Hits 6428 6433 +5
- Misses 2197 2201 +4
- Partials 452 453 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BogusTrustManagerFactory
Updated comment to reflect the correct version of Apache MINA from which the code was copied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINA 2.2.10 will remove
BogusTrustManagerFactory. To ease the migration for people who want to run MINA 2.2.10 with QFJ (by using MINA 2.2.10 at runtime) we will simply copy the factory over to QFJ.NOTE: upgrading to MINA 2.2.10 is currently not advised when using SSL in combination with proxy. See #1348 and apache/mina#84
Summary
BogusTrustManagerFactoryinto QuickFIX/J's SSL package