Repository navigation
feat(spark): add opt-in ordered reads and JMH comparison - #120
Open
ChristopherWirt wants to merge 2 commits into
Open
ChristopherWirt wants to merge 2 commits into
ChristopherWirt wants to merge 2 commits into
Conversation
Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spark currently returns a Vortex file's decoded chunks in completion order, so callers that consume users in stored order cannot request that ordering through the connector. Add
vortex.read.ordered: whentrue, the shared V1/V2 reader builds its scan withordered(true). The option defaults tofalse, preserving existing Spark read behavior.Related to #76, with ordering exposed as an opt-in option. The guarantee applies within each file split; it does not establish ordering across Spark partitions or files.
Changes
VortexPartitionReader; schema inference is outside the timed region.Representative measurements on a current bid-hour event file and featoid bucket are still pending. Enabling the option in downstream
StoreFilesand removing run splitting are follow-ups contingent on those results; the check rejecting out-of-order users should remain.Testing
./gradlew spotlessApplyfromjava/, covering the root and all subprojects; reviewed the resulting diff.VortexOptionsTest,VortexPartitionReaderLifecycleTest, andVortexFileSplitTest.orderedReadsPreserveRowOrder(23 test cases; the ordering regression exercises 12 read scenarios). Temporarily removing the option forwarding made the regression fail for all three reader modes; restoring it passed.ordered=falseandordered=true, decoding all five columns of an existing 10,565,924-byte featoid file.