FROMLIST: OPP: debugfs: Use performance level if available to distinguish between rates

[ziyuezhang-123]

OPP: debugfs: Use performance level if available to distinguish between rates

Some OPP tables have entries with same rate and different performance
level. For these entries, using only the rate as the debugfs directory name
causes below error:

debugfs: 'opp:5000000' already exists in 'soc@0-1c00000.pci'

Fix it by appending the performance level to the dir name if available.

Link: https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com

CRs-Fixed: 4562248

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4562248 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4562248

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #1262 — validate-patch

PR: #1262

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com
2. Lore link matches PR commits: No — PR patch file contains only commit message; code diff is completely missing (lore patch modifies drivers/opp/debugfs.c with 11 insertions, 9 deletions)
3. Upstream patch status: ✅ ACKed — Viresh Kumar (OPP maintainer) confirmed "Applied. Thanks." on 2026-01-30 07:39 UTC
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1262 - FROMLIST: OPP: debugfs: Use performance level if available to distinguish between rates
Upstream commit: https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	✅	FROMLIST: prefix added correctly; base subject identical
Body preserves rationale	✅	Bug description, error message, and fix rationale preserved
Fixes tag present/correct	✅	Fixes: 05db35963eef matches lore patch
Authorship preserved	⚠️	From: matches lore author (correct for FROMLIST:); lore author's Signed-off-by: present; additional Signed-off-by: from submitter Ziyue Zhang added (expected for FROMLIST:)
Backport note (if applicable)	N/A	Not a backport — FROMLIST: commit

Diff

File	Status	Notes
drivers/opp/debugfs.c	❌	PR patch contains NO diff — only commit message present

Issues

1. Critical: Missing code diff — The PR patch file (pr.patch) contains only the commit message (20 lines) with no actual code changes. The lore patch includes a complete diff modifying drivers/opp/debugfs.c (changes to opp_debug_create_one function, adding performance level to debugfs directory names). The PR cannot be validated or merged without the actual code changes.

2. Authorship note (informational, not an error) — The PR adds Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> as the submitter. For FROMLIST: commits, this is correct: the original author (Manivannan Sadhasivam) remains in From: and has their Signed-off-by: preserved, while the person cherry-picking and submitting the PR adds their own Signed-off-by:. This follows kernel DCO chain-of-custody rules.

Upstream Patch Status

Commit	Community Verdict
OPP: debugfs: Use performance level if available to distinguish between rates	✅ ACKed — Viresh Kumar (maintainer) replied "Applied. Thanks." on 2026-01-30

Verdict

Reject — The PR patch file is incomplete and contains no code diff. The commit message is faithful to the lore source and the upstream patch has been accepted by the maintainer, but without the actual code changes, this PR cannot be merged. The PR must be regenerated to include the full diff from the lore patch.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com
2. Lore link matches PR commits: No — PR patch file contains only commit message; code diff is completely missing (lore patch modifies drivers/opp/debugfs.c with 11 insertions, 9 deletions)
3. Upstream patch status: ✅ ACKed — Viresh Kumar (OPP maintainer) confirmed "Applied. Thanks." on 2026-01-30 07:39 UTC
4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified" (likely because the PR patch is incomplete)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] FROMLIST: OPP: debugfs: Use performance level if available to	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

[qlijarvis]

PR #1262 — checker-log-analyzer

PR: #1262
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37875510557

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	ERROR: Does not appear to be a unified-diff format patch
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	⏭️	Nothing changed
check-uapi-headers	⏭️	Nothing changed
check-patch-compliance	❌	Change is different from the one mentioned in Link
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1262 - FROMLIST: OPP: debugfs: Use performance level if available to distinguish between rates
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37875510557
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	❌	ERROR: Does not appear to be a unified-diff format patch
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	⏭️	Nothing changed
check-uapi-headers	⏭️	Nothing changed
check-patch-compliance	❌	Change is different from the one mentioned in Link
tag-check	✅	Subject has valid FROMLIST: prefix

---

❌ checkpatch

Root cause: checkpatch encountered a malformed commit that does not appear to be in unified-diff format.

Failure details:

ERROR: Does not appear to be a unified-diff format patch

3f564a7052a5d2f48706633b208502acb15e2ca0 total: 1 errors, 0 warnings, 0 checks, 0 lines checked

Commit 3f564a7052a5 ("FROMLIST: OPP: debugfs: Use performance level if available to distinguish between rates") has style problems, please review.

Analysis:
This error typically occurs when:

1. The commit is empty (no actual code changes, only commit message)
2. The commit has been corrupted or improperly formatted
3. The git object is malformed

Given that all other checkers skipped (no DTS, no C/H files changed), this suggests the commit may be empty or contain only metadata changes that checkpatch cannot parse.

Fix:
Verify the commit contains actual code changes:

git show 3f564a7052a5d2f48706633b208502acb15e2ca0 --stat
git show 3f564a7052a5d2f48706633b208502acb15e2ca0

If the commit is empty or malformed, recreate it with the proper changes. If it contains valid changes, this may be a checkpatch limitation with the specific diff format.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git f19f3cdab691f3d6d8bcccf03e46669ba4e714ea..3f564a7052a5d2f48706633b208502acb15e2ca0

---

❌ check-patch-compliance

Root cause: The patch content in the PR differs from the upstream patch referenced in the Link trailer.

Failure details:

Checking commit: FROMLIST: OPP: debugfs: Use performance level if available to distinguish between rates
Change is different from the one mentioned in Link

Analysis:
The commit references Link: https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com but the actual code changes in the PR do not match the upstream patch at that link. This can happen due to:

1. Context-only differences — surrounding lines changed but the actual fix is identical (false positive)
2. Legitimate adaptations — the patch was modified for the target kernel version
3. Missing hunks — some changes from upstream were omitted
4. Extra hunks — additional changes not in the upstream patch

Fix:
Fetch the upstream patch and compare:

b4 am --single-message -C -l -3 https://lore.kernel.org/r/20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com -o /tmp/out
git format-patch -1 3f564a7052a5d2f48706633b208502acb15e2ca0 --stdout > /tmp/pr.patch
diff <(awk '/^diff/,/^--$/' /tmp/pr.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

Resolution options:

• If differences are context-only (line numbers shifted) → acceptable, document in commit message
• If legitimate adaptation for qcom-6.18.y → change prefix to BACKPORT: and document changes
• If missing hunks → add them
• If extra hunks → remove or attribute separately

---

Verdict

2 blockers must be fixed before merge:

1. checkpatch failure — The commit appears malformed or empty. Verify the commit contains actual code changes and is properly formatted. This may indicate the commit was not correctly cherry-picked or rebased.

2. check-patch-compliance failure — The patch content differs from the upstream link. Investigate whether this is a legitimate backport adaptation (requiring BACKPORT: prefix) or an error in the cherry-pick process.

Recommended action:
Verify the commit 3f564a7052a5d2f48706633b208502acb15e2ca0 contains the expected code changes by inspecting git show 3f564a7052a5. If the commit is valid but adapted for qcom-6.18.y, change the prefix from FROMLIST: to BACKPORT: and document the adaptations in the commit message.