Repository navigation
FROMLIST: PCI: qcom: Disable halting feature - #2010
Open
krishnachaitanya-linux wants to merge 1 commit into
Open
krishnachaitanya-linux wants to merge 1 commit into
krishnachaitanya-linux wants to merge 1 commit into
Conversation
The PARF write, read and BDF halt features make the controller wait for earlier AXI transactions to complete before issuing new ones. This is needed on SoCs whose NoC cannot preserve the ordering of inbound transactions from the controller. On newer SoCs, the NoC preserves this ordering on its own. Halting at the controller adds no correctness benefit and reduces inbound DMA bandwidth. Add a noc_ensures_ordering flag to struct qcom_pcie_cfg. Clear all three halt features on SoCs that set it. Other SoCs keep enabling write halt as before. Link: https://patch.msgid.link/20261009-halt-v1-1-4a2d7899d91f@oss.qualcomm.com Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
qcomlnxci
requested review from
a team and
Matthew Leung (meleung)
and removed request for
a team
October 9, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PARF write, read and BDF halt features make the controller wait for earlier AXI transactions to complete before issuing new ones. This is needed on SoCs whose NoC cannot preserve the ordering of inbound transactions from the controller.
On newer SoCs, the NoC preserves this ordering on its own. Halting at the controller adds no correctness benefit and reduces inbound DMA bandwidth.
Add a noc_ensures_ordering flag to struct qcom_pcie_cfg. Clear all three halt features on SoCs that set it. Other SoCs keep enabling write halt as before.
Link: https://patch.msgid.link/20261009-halt-v1-1-4a2d7899d91f@oss.qualcomm.com