DNM: spmi: Add debugs for coral workflow test

[raryan-qcom]

No description provided.

[qlijarvis]

PR #1965 — validate-patch

PR: #1965

Verdict	Issues	Detailed Report
❌	4	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for temporary debug patches
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — temporary debug code, not posted upstream and not intended for upstream
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream source; DNM prefix indicates temporary debug patch
Body preserves rationale	❌	No explanation of debug purpose or workflow context
Fixes tag present/correct	N/A	Not a fix; debug instrumentation only
Authorship preserved	✅	Signed-off-by present
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/spmi/spmi-pmic-arb.c	❌	Adds debug pr_err() with hardcoded name; not production-ready

Issues

• No commit message body: The patch adds debug code but provides no explanation of what "coral workflow test" means or why this instrumentation is needed
• Debug code quality: Uses pr_err() for non-error debug output; should use pr_debug() or dev_dbg() instead
• Hardcoded name: "Mohan" appears to be a developer name; debug messages should be descriptive, not personal
• DNM prefix without context: While DNM correctly signals "do not merge," the commit message should explain the temporary nature and intended removal timeline

Verdict

Do not merge. This is a temporary debug patch (DNM prefix) that is not suitable for any production branch. If this debug instrumentation is genuinely needed for testing, it should:

1. Include a commit message explaining the test scenario and expected removal timeline
2. Use appropriate debug macros (pr_debug or dev_dbg) instead of pr_err
3. Use descriptive messages instead of personal names
4. Be tracked separately from production code paths

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for temporary debug patches
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — temporary debug code, not posted upstream and not intended for upstream
4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (expected for DNM patches, but confirms this is not production-ready code)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: spmi: Add debugs for coral workflow test	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1965 — checker-log-analyzer

PR: #1965
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37762936873

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 warnings: missing commit description, unnecessary whitespace (2×)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required prefix
tag-check	❌	Subject missing valid prefix (DNM: not allowed)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37762936873

Checker	Result	Summary
checkpatch	❌	3 warnings: missing commit description, unnecessary whitespace (2×)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required prefix
tag-check	❌	Subject missing valid prefix (DNM: not allowed)

---

❌ checkpatch

Root cause: Commit has coding style violations — missing commit description and unnecessary whitespace in debug strings.

Failure details:

Commit 3d4045123176 ("DNM: spmi: Add debugs for coral workflow test")

WARNING: Missing commit description - Add an appropriate one

WARNING: unnecessary whitespace before a quoted newline
#19: FILE: drivers/spmi/spmi-pmic-arb.c:2088:
+	pr_err(" Jagan: Probe called \n");

WARNING: unnecessary whitespace before a quoted newline
#20: FILE: drivers/spmi/spmi-pmic-arb.c:2089:
+	pr_err(" Mohan: Probe \n");

3d4045123176d855fce07ff304d0b6ddf0e08a48 total: 0 errors, 3 warnings, 0 checks, 9 lines checked

Fix:

1. Add commit description — expand the commit message body to explain why these debug statements are being added:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend
   # In the editor, add a commit body after the subject line:
   #
   # Add temporary debug prints to the SPMI PMIC arbiter probe function
   # to trace execution flow during coral workflow testing.
   #
   # Signed-off-by: Raj Aryan <raryan@qti.qualcomm.com>

2. Remove trailing whitespace before \n in the pr_err() calls:

   # Edit drivers/spmi/spmi-pmic-arb.c
   # Change:
   pr_err(" Jagan: Probe called \n");
   pr_err(" Mohan: Probe \n");
   # To:
   pr_err(" Jagan: Probe called\n");
   pr_err(" Mohan: Probe\n");
   
   git add drivers/spmi/spmi-pmic-arb.c
   git commit --amend --no-edit
   git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 0f2f8dcc603eaa56171859152e2c03549f475532..416b920ba586258a765c5b1098c43cedaaff819a

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: DNM: spmi: Add debugs for coral workflow test
Commit summary does not start with a required prefix

The commit subject starts with DNM: (Do Not Merge), which is not in the allowed prefix list for check-patch-compliance. This checker enforces that commits must be traceable to upstream sources.

Fix:

Since this is a temporary debug patch (indicated by "DNM:"), you have two options:

Option 1 — If this is vendor-only debug code:
Change the prefix to QCLINUX: (though note: check-patch-compliance will still fail for QCLINUX: — this is a known checker limitation for vendor-only commits):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: spmi: Add debugs for coral workflow test"
git rebase --continue

Option 2 — If this should not be merged at all:
Keep the DNM: prefix and acknowledge that check-patch-compliance will fail. The DNM: prefix signals that this commit is intentionally not for merge and is used only for testing/debugging purposes. In this case, the CI failure is expected and acceptable.

Note: The check-patch-compliance checker only accepts upstream-traceable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). Vendor-specific prefixes like QCLINUX:, PENDING:, WORKAROUND:, and DNM: will always fail this check — this is a known limitation of the checker.

---

❌ tag-check

Root cause: Commit subject does not start with a valid prefix tag required for all branches except qcom-next and qcom-next-staging.

Failure details:

Commit 3d4045123176 ("DNM: spmi: Add debugs for coral workflow test")
Subject line starts with "DNM:" which is not a recognized prefix.

Required prefixes:

• FROMLIST: — Patch posted to mailing list (lore.kernel.org)
• FROMGIT: — Patch taken from a maintainer git tree
• UPSTREAM: — Patch merged into Linus's mainline tree
• BACKPORT: — Upstream patch backported with modifications
• QCLINUX: — Vendor-only change with no upstream equivalent
• PENDING: — Work-in-progress, not yet posted upstream
• WORKAROUND: — Temporary fix not suitable for upstream

Fix:

Since this is a debug/test patch (indicated by "DNM: Do Not Merge"), the most appropriate prefix would be QCLINUX: or WORKAROUND::

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: spmi: Add debugs for coral workflow test"
# Or if truly temporary:
git commit --amend -m "WORKAROUND: spmi: Add debugs for coral workflow test"
git rebase --continue

Note: If the target branch is qcom-next or qcom-next-staging, this check does not apply. However, based on the PR being in kernel-topics repo, it's likely targeting a different branch where the prefix is mandatory.

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Add commit description and remove trailing whitespace before \n in pr_err() calls
2. check-patch-compliance — Change prefix from DNM: to a valid prefix (recommend QCLINUX: or WORKAROUND: for debug code)
3. tag-check — Same as dummy change #2 — use a valid prefix tag

Quick fix summary:

git rebase -i <base_sha>
# Mark commit as 'edit'

# Fix the code
sed -i 's/ \\n/\\n/g' drivers/spmi/spmi-pmic-arb.c
git add drivers/spmi/spmi-pmic-arb.c

# Fix commit message
git commit --amend
# Change subject to: QCLINUX: spmi: Add debugs for coral workflow test
# Add body:
#
# Add temporary debug prints to the SPMI PMIC arbiter probe function
# to trace execution flow during coral workflow testing.
#
# Signed-off-by: Raj Aryan <raryan@qti.qualcomm.com>

git rebase --continue

Note: If this is truly a "Do Not Merge" test commit that should never be merged, you may choose to leave it as-is and accept the CI failures as expected. The DNM: prefix is a convention to mark commits that are intentionally not for merge.

[qlijarvis]

PR #1965 — validate-patch

PR: #1965

Verdict	Issues	Detailed Report
⚠️	4	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for debug patches
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM debug patch, not intended for upstream submission
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Upstream commit: N/A
Verdict: ⚠️ PARTIAL (DNM: debug patch — not intended for merge)

Commit Message

Check	Status	Note
Subject matches upstream	N/A	DNM: prefix; no upstream equivalent
Body preserves rationale	⚠️	No commit body explaining debug purpose
Fixes tag present/correct	N/A	Debug patch, not a fix
Authorship preserved	✅	Authored by Raj Aryan
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/spmi/spmi-pmic-arb.c	⚠️	Adds debug pr_err() with hardcoded name "Mohan"

Issues

• DNM patch in PR: The DNM: (Do Not Merge) prefix indicates this is a temporary debug patch. It should not be merged into any production branch.
• Missing commit body: No explanation of why this debug is needed or what "coral workflow test" refers to.
• Debug code quality: The debug message contains a hardcoded name ("Mohan") and trailing whitespace, which would fail checkpatch if this were intended for upstream.
• Not present in integration branches: The patch is missing from both qcom-next and topics, which is expected for a DNM debug patch but confirms it should not be merged.

Verdict

Do not merge. This is a temporary debug patch marked DNM: (Do Not Merge). If this debug logging is needed for testing, it should remain in a local development branch or be removed after the "coral workflow test" is complete. If the functionality is needed long-term, it should be reimplemented as proper tracepoints or dynamic debug statements and submitted with a proper commit message explaining the use case.

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for debug patches
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM debug patch, not intended for upstream submission
4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (expected for DNM patches, but confirms this should not be merged)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: spmi: Add debugs for coral workflow test	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1965 — checker-log-analyzer

PR: #1965
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37883992255

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 warnings: missing commit description, unnecessary whitespace before quoted newlines
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject does not start with required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37883992255

Checker	Result	Summary
checkpatch	❌	3 warnings: missing commit description, unnecessary whitespace before quoted newlines
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject does not start with required prefix

---

❌ checkpatch

Root cause: Commit has missing description and unnecessary whitespace in pr_err() statements.

Failure details:

WARNING: Missing commit description - Add an appropriate one

WARNING: unnecessary whitespace before a quoted newline
#19: FILE: drivers/spmi/spmi-pmic-arb.c:2088:
+	pr_err(" Jagan: Probe called \n");

WARNING: unnecessary whitespace before a quoted newline
#20: FILE: drivers/spmi/spmi-pmic-arb.c:2089:
+	pr_err(" Reddy: Probe \n");

a7941d49710597d2f93372b6d63805721c2a735c total: 0 errors, 3 warnings, 0 checks, 9 lines checked

Fix:

1. Add a commit description explaining why these debug statements are being added
2. Remove trailing space before \n in both pr_err() calls:

   pr_err("Jagan: Probe called\n");
   pr_err("Reddy: Probe\n");

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a5b10ef19d5b18ad7921750767f64d86d64c2d3c..1a0bcf7b6a80aab490338af1275b9bb370b1bc90

---

❌ check-patch-compliance

Root cause: Commit subject "DNM: spmi: Add debugs for coral workflow test" does not start with a required prefix.

Failure details:

Checking commit: DNM: spmi: Add debugs for coral workflow test
Commit summary does not start with a required prefix

Fix:

The check-patch-compliance checker requires one of these prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Since this is a debug/test commit (indicated by "DNM" - Do Not Merge), the appropriate action depends on intent:

• If this is vendor-only debug code: Use QCLINUX: prefix (note: this will still fail check-patch-compliance but is the correct semantic prefix)
• If this will be posted upstream: Use FROMLIST: and add a Link: trailer
• If this is truly temporary: Use PENDING: or WORKAROUND: prefix (note: these also fail the checker)

Note: DNM: is not a recognized prefix. The checker enforces upstream-linkable prefixes only. For vendor-only or temporary commits, this is a known limitation of the checker.

---

❌ tag-check

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Commit a7941d4 ("DNM: spmi: Add debugs for coral workflow test"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

• FROMLIST: - Patch posted to mailing list (lore.kernel.org)
• FROMGIT: - Patch taken from a maintainer git tree
• UPSTREAM: - Patch merged into Linus's mainline tree
• BACKPORT: - Upstream patch backported with modifications
• QCLINUX: - Vendor-only change with no upstream equivalent
• PENDING: - Work-in-progress, not yet posted upstream
• WORKAROUND: - Temporary fix not suitable for upstream

Fix:

Since this is a debug commit for workflow testing (DNM = Do Not Merge), the appropriate prefix is likely QCLINUX: or PENDING::

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: spmi: Add debugs for coral workflow test"
# or
git commit --amend -m "PENDING: spmi: Add debugs for coral workflow test"
git rebase --continue

Then add a proper commit body explaining the purpose of these debug statements.

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch - Add commit description and remove trailing spaces in pr_err() statements
2. check-patch-compliance - Add required subject prefix (QCLINUX: or PENDING: recommended for debug/test code)
3. tag-check - Same as dummy change #2 (subject prefix requirement)

Note: This appears to be a temporary debug commit (DNM prefix). If this is intended for testing only and not for permanent merge, consider whether it should go through the normal PR process or be handled differently in the workflow.

[qlijarvis]

PR #1965 — validate-patch

PR: #1965

Verdict	Issues	Detailed Report
N/A	2	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for test-only commits
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor test-only change, not posted upstream and not intended for upstream
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1965 — DNM: spmi: Add debugs for coral workflow test
Upstream commit: N/A
Verdict: ⏭️ SKIP (not applicable)

Reason

This commit uses the DNM: (Do Not Merge) prefix, which indicates a temporary debug/test change not intended for upstream or production merge. No lore.kernel.org link is present or expected.

The patch adds a debug pr_err() statement to spmi_pmic_arb_probe() for workflow testing purposes. This is a vendor-only, temporary change similar to QCLINUX:, PENDING:, or WORKAROUND: commits.

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream source; DNM prefix indicates test-only commit
Body preserves rationale	N/A	No upstream to compare against
Fixes tag present/correct	N/A	Not a fix; debug addition for testing
Authorship preserved	✅	Author: Raj Aryan; Signed-off-by present
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/spmi/spmi-pmic-arb.c	⚠️	Adds debug pr_err() — acceptable for DNM test commit, but should not be merged to production

Issues

• Debug statement in production code: The patch adds pr_err("Jagan Reddy: Probe called \n"); to the probe function. This is appropriate for a DNM: test commit but must not be merged into any production branch.
• Trailing whitespace: The pr_err() line has a trailing space before \n — minor style issue.

Verdict

Do not merge. This is a DNM: (Do Not Merge) test commit intended for workflow validation only. The debug statement should be removed before any production merge. If this commit was created for CI/workflow testing purposes, it should be reverted or dropped from the branch after testing is complete.

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required for test-only commits
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor test-only change, not posted upstream and not intended for upstream
4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md). This is expected for a DNM: test commit that should not be integrated into production branches.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: spmi: Add debugs for coral workflow test	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1965 — checker-log-analyzer

PR: #1965
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38117112058

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: missing commit description, unnecessary whitespace
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (topic branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38117112058

Checker	Result	Summary
checkpatch	❌	2 warnings: missing commit description, unnecessary whitespace
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (topic branch)

---

❌ checkpatch

Root cause: Commit has missing description and code style issue with whitespace before newline.

Failure details:

WARNING: Missing commit description - Add an appropriate one

WARNING: unnecessary whitespace before a quoted newline
#19: FILE: drivers/spmi/spmi-pmic-arb.c:2088:
+	pr_err("Jagan Reddy: Probe called \n");

40574c4be5f812072b82d2a02bb301b45132cd94 total: 0 errors, 2 warnings, 0 checks, 8 lines checked

Fix:

1. Missing commit description: Add a proper commit body explaining why this debug is needed:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend
   # Add commit body, e.g.:
   # "Add temporary debug print to verify probe sequence in coral workflow testing.
   # This is a DNM (Do Not Merge) commit for debugging purposes only."

2. Whitespace before newline: Remove the space before \n:

   # Edit drivers/spmi/spmi-pmic-arb.c:2088
   -	pr_err("Jagan Reddy: Probe called \n");
   +	pr_err("Jagan Reddy: Probe called\n");
   
   git add drivers/spmi/spmi-pmic-arb.c
   git commit --amend --no-edit
   git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: DNM: spmi: Add debugs for coral workflow test
Commit summary does not start with a required prefix

Fix:

The subject line starts with DNM: which is not in the allowed prefix list. Since this is a vendor-only debug commit (Do Not Merge), the appropriate action depends on the branch policy:

• If this is for a topic branch (like topic/tech/pmic/misc): Topic branches may have different prefix requirements. However, check-patch-compliance enforces upstream-linkable prefixes only.

• Recommended fix: Add QCLINUX: prefix (vendor-only) or PENDING: prefix:

  git rebase -i <base_sha>   # mark commit as 'edit'
  git commit --amend -m "QCLINUX: DNM: spmi: Add debugs for coral workflow test"
  git rebase --continue

Note: QCLINUX: and PENDING: prefixes are known to fail check-patch-compliance because the checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known limitation for vendor-only commits. Since this is a DNM commit, it's not intended for upstream, so this failure is expected.

Reproduce locally:

# The checker validates that commits have upstream-linkable prefixes
# For vendor-only DNM commits, this check will always fail

---

❌ tag-check

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Commit 40574c4be5f8 ("DNM: spmi: Add debugs for coral workflow test"): subject line does not start with a required prefix.

The target branch is topic/tech/pmic/misc. Based on the skill workflow:

• If the target branch is not qcom-next or qcom-next-staging, every commit must start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.

Fix:

Since this is a DNM (Do Not Merge) debug commit for vendor testing, use the QCLINUX: prefix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: DNM: spmi: Add debugs for coral workflow test"
git rebase --continue

Choose the correct prefix based on the patch origin:

• Vendor-only, no upstream → QCLINUX:
• Work-in-progress, not posted → PENDING:
• Temporary fix, not for upstream → WORKAROUND:

---

Verdict

3 blockers to fix before merge:

1. checkpatch: Add commit description body and remove whitespace before \n in pr_err() call
2. check-patch-compliance: Add QCLINUX: prefix (note: this will still fail the checker due to known limitation for vendor-only commits)
3. tag-check: Add QCLINUX: prefix to meet branch policy requirements

Recommended action: Since this is a DNM (Do Not Merge) commit for debugging purposes, consider whether it should be merged at all. If it must be merged temporarily:

• Fix the code style issues (whitespace, commit description)
• Add QCLINUX: prefix to satisfy branch policy
• Accept that check-patch-compliance will fail for vendor-only commits (known limitation)
• Ensure this commit is reverted before any upstream submission

[qlijarvis]

PR #1965 — validate-patch

PR: #1965

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required (temporary debug commit)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM (Do Not Merge) commit, not intended for upstream submission
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Upstream commit: N/A
Verdict: ⚠️ PARTIAL (DNM commit — temporary debug change)

Commit Message

Check	Status	Note
Subject matches upstream	N/A	DNM: prefix — no upstream equivalent
Body preserves rationale	⚠️	Missing explanation of debug purpose
Fixes tag present/correct	N/A	Debug commit, not a fix
Authorship preserved	✅	Signed-off-by present
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/spmi/spmi-pmic-arb.c	⚠️	Adds pr_err debug statement for workflow testing

Issues

• Missing commit body: The commit message should explain why this debug is needed and what workflow is being tested
• Debug statement quality: pr_err("Jagan : Probe called \n") should use pr_debug() instead of pr_err() for non-error debug output, and should remove trailing space before \n
• DNM commit in PR: This commit should be reverted before merging to qcom-next or any integration branch

Verdict

Do not merge as-is. This is a temporary debug commit (DNM: prefix) intended for coral workflow testing. It should be reverted before final integration. If this debug is needed for testing, ensure it's removed from the final patch series.

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected or required (temporary debug commit)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM (Do Not Merge) commit, not intended for upstream submission
4. PR present in qcom-next/topics: Fail — 1/1 commit missing from both qcom-next and topics (expected for DNM commits; should remain absent)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: spmi: Add debugs for coral workflow test	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1965 — checker-log-analyzer

PR: #1965
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38126642200

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: missing commit description, whitespace before quoted newline
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (applies to topic branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1965 - DNM: spmi: Add debugs for coral workflow test
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38126642200

Checker	Result	Summary
checkpatch	❌	2 warnings: missing commit description, whitespace before quoted newline
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (applies to topic branches)

---

❌ checkpatch

Root cause: Commit has missing commit description and unnecessary whitespace in pr_err() statement.

Failure details:

WARNING: Missing commit description - Add an appropriate one

WARNING: unnecessary whitespace before a quoted newline
#19: FILE: drivers/spmi/spmi-pmic-arb.c:2088:
+	pr_err("Jagan : Probe called \n");

fd49b5303db119bfde5c279cafd890adf33d2b2a total: 0 errors, 2 warnings, 0 checks, 8 lines checked

Fix:

1. Missing commit description: Add a commit body explaining why this debug statement is needed:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend
   # Add commit body, e.g.:
   # "Add temporary debug print to verify SPMI PMIC arbiter probe
   # is called during coral workflow testing."
   git rebase --continue

2. Whitespace before newline: Remove the space before \n:

   # Edit drivers/spmi/spmi-pmic-arb.c:2088
   -	pr_err("Jagan : Probe called \n");
   +	pr_err("Jagan : Probe called\n");
   
   git add drivers/spmi/spmi-pmic-arb.c
   git commit --amend --no-edit

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

---

❌ check-patch-compliance

Root cause: Commit subject "DNM: spmi: Add debugs for coral workflow test" does not start with a required prefix.

Failure details:

Checking commit: DNM: spmi: Add debugs for coral workflow test
Commit summary does not start with a required prefix

Fix:

The DNM: (Do Not Merge) prefix is not recognized by the checker. Since this is a temporary debug patch for workflow testing, you have two options:

1. If this is vendor-only and will never go upstream: Use QCLINUX: prefix:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend -m "QCLINUX: DNM: spmi: Add debugs for coral workflow test"
   git rebase --continue

   Note: QCLINUX: is a known limitation — the checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), so this will still fail check-patch-compliance but documents the intent correctly.

2. If this is truly temporary test code: Use PENDING: prefix:

   git commit --amend -m "PENDING: DNM: spmi: Add debugs for coral workflow test"

   Note: Same limitation as QCLINUX: — will still fail the checker.

3. Best option for CI pass: Since this is a debug patch, consider using WORKAROUND: prefix (if supported) or accept that vendor-only debug patches will fail this checker.

Important: The check-patch-compliance checker enforces upstream-linkable prefixes only. Vendor-only debug patches with DNM:, QCLINUX:, or PENDING: will always fail this check — this is a known checker limitation.

---

❌ tag-check

Root cause: Commit subject does not start with a required prefix tag. This check applies because the PR targets a topic branch (topic/tech/pmic/misc), not qcom-next or qcom-next-staging.

Failure details:

Commit fd49b5303db1 ("DNM: spmi: Add debugs for coral workflow test"):
Subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

• FROMLIST: — Patch posted to mailing list (lore.kernel.org)
• FROMGIT: — Patch taken from a maintainer git tree
• UPSTREAM: — Patch merged into Linus's mainline tree
• BACKPORT: — Upstream patch backported with modifications
• QCLINUX: — Vendor-only change with no upstream equivalent
• PENDING: — Work-in-progress, not yet posted upstream
• WORKAROUND: — Temporary fix not suitable for upstream

Fix:

Since this is a temporary debug patch for workflow testing, use the QCLINUX: prefix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: DNM: spmi: Add debugs for coral workflow test"
git rebase --continue

This documents that it's a vendor-only debug change not intended for upstream.

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch: Add commit body description and remove whitespace before \n in pr_err()
2. check-patch-compliance: Add QCLINUX: prefix (note: will still fail checker due to known limitation)
3. tag-check: Add QCLINUX: prefix to satisfy subject-line tagging requirement

Recommended action:

git rebase -i <base_sha>
# Mark commit as 'edit'

# Fix the code
sed -i 's/Probe called \\n/Probe called\\n/' drivers/spmi/spmi-pmic-arb.c
git add drivers/spmi/spmi-pmic-arb.c

# Fix commit message
git commit --amend
# Change subject to: QCLINUX: DNM: spmi: Add debugs for coral workflow test
# Add body:
#   Add temporary debug print to verify SPMI PMIC arbiter probe
#   is called during coral workflow testing. This is a debug-only
#   change not intended for upstream submission.

git rebase --continue

Note: Even after adding QCLINUX: prefix, the check-patch-compliance checker will still fail because it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known limitation for vendor-only debug patches. The tag-check requirement will be satisfied, and checkpatch will pass after the fixes.