Skip to content

chore: fix README links, add LICENSE - #467

Merged
SpertsyanKM merged 2 commits into
qonversion:mainfrom
Vlada-Q:marketing/hygiene-2026-09
Oct 9, 2026
Merged

SpertsyanKM merged 2 commits into
qonversion:mainfrom
Vlada-Q:marketing/hygiene-2026-09

Conversation

@Vlada-Q

@Vlada-Q Vlada-Q commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Two broken links, both from the shared README template.

  • [All other integrations here](qonversion.io/integrations) has no scheme. GitHub renders it as a repository-relative path, so on the rendered README it resolves to github.com/qonversion/react-native-sdk/blob/main/qonversion.io/integrations and 404s. Now https://qonversion.io/integrations (200).
  • https://documentation.qonversion.io/discuss-new in Have a question? is left over from readme.io and returns 404 — it is not among the redirects the docs site keeps. That is the link a reader follows when something did not work. It now points at https://qonversion.io/contact-us (200), next to the existing GitHub issues link. The same target is used in the other SDK READMEs so the support channel is one and the same everywhere.

No licence text in the repository. The README ends with «Qonversion SDK is available under the MIT license» and carries an MIT badge, but there is no LICENSE file and the GitHub API reports license: null for this repository — so formally the licence exists only as a claim. For a team running a legal review before adopting an SDK, that is a stopper.

Added LICENSE with the MIT text copied from qonversion-ios-sdk, copyright holder unchanged (Qonversion team <hi@qonversion.io>). The badge now links to that file instead of the #license anchor inside the README.


Scope is deliberately narrow: links, licence, install, typo. Positioning, the opening paragraph, the bullets, the banner images and the version badge are untouched — those belong to the README template being rewritten separately.

Opened from a fork, so the review request could not be set from here — @SpertsyanKM, this one is for you.

🤖 Generated with Claude Code

Vlada-Q and others added 2 commits September 22, 2026 14:56
`[All other integrations here](qonversion.io/integrations)` has no scheme,
so GitHub renders it as a repository-relative path and it 404s where the
README is actually read. `https://documentation.qonversion.io/discuss-new`
is left over from readme.io and 404s too — it sits in "Have a question?",
which is exactly where a reader goes when something did not work. It now
points at the contact form on the site, next to the existing issues link.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The README states the SDK is available under the MIT license and carries
an MIT badge, but the repository has no licence text in any form and the
GitHub API reports `license: null`. The text is the one used in
qonversion-ios-sdk, unchanged. The badge now links to the file instead of
an anchor inside the README.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: qonversion/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 37e55366-6561-4726-b8d8-77718a41c584

📥 Commits

Reviewing files that changed from the base of the PR and between a7e7127 and b359aab.

📒 Files selected for processing (2)
  • LICENSE
  • README.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • qonversion/go-micro (manual)

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The pull request adds an MIT license and updates three README links. The changes cover the license badge, integrations URL, and contact link.

Changes

License and README

Layer / File(s) Summary
License terms and README links
LICENSE, README.md
The repository adds MIT license terms. The README license badge links to LICENSE, the integrations link uses HTTPS, and the contact link points to the contact form.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b359a

The PR adds MIT licensing and corrects three README links; this documentation-only change has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Behavior And Regression Safety ✅ Passed The diff changes only README links and adds the MIT LICENSE file. The two replacement URLs return HTTP 200, while the removed documentation URL returns HTTP 404. The integrations link now has an HTTPS…
Security And Tenant Isolation ✅ Passed PASS. The authoritative diff changes only README.md and a new static LICENSE file. The README changes are link targets only, and the license text adds no executable behavior, permissions, authenti…
Contract And Data Compatibility ✅ Passed The authoritative diff changes only README.md and adds LICENSE. The changes update documentation links, the license badge target, and add MIT license text. No API, event, database, configuration, …
Rollout And Recovery Evidence ✅ Passed PASS. The reviewed range changes only LICENSE and README.md. It adds MIT license text and updates documentation links. It does not change production behavior, configuration, infrastructure, or migrati…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the affected repository areas, README links and licensing, and states the behavioral outcomes: fix links and add the LICENSE file.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@SpertsyanKM
SpertsyanKM merged commit 738a683 into qonversion:main Oct 9, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants