Add OpenMP to build and enable 5-D multilinear interpolation - #131
Open
djhoese wants to merge 1 commit into
Open
Add OpenMP to build and enable 5-D multilinear interpolation#131djhoese wants to merge 1 commit into
djhoese wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 89.04% 94.26% +5.22%
==========================================
Files 20 20
Lines 1515 1605 +90
==========================================
+ Hits 1349 1513 +164
+ Misses 166 92 -74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude pointed out that 5D interpolation wasn't enabled in the multilinear module, something I'd noticed before. Claude also pointed out that multilinear uses
prangewhich is an OpenMP multithreading pragma, but geotiepoints was never built with the necessary openmp flags to use it. Claude's understanding is that this isn't a problem and the interpolation should work like this. If the original author of these interpolators knows (@mraspaud @adybbroe ?) for sure, it'd be great to nail this down.Claude's benchmark results:
I told Claude to pick OpenMP knowledge from pykdtree where OpenMP has been a feature for a long time.
git diff origin/main **/*py | flake8 --diff