Remove unfinished array and bindless texture atlas stubs - #2904
Merged
Merged
Conversation
arcade/texture_atlas/atlas_array.py and atlas_bindless.py were added as empty placeholders in #1951 (January 2024), marked "WORK IN PROGRESS. DO NOT USE." Neither was imported or exported anywhere, and neither class could be instantiated, since they implement none of TextureAtlasBase's abstract methods. Both have failed to import on Python 3.10-3.13 since "Drop 3.9" (#2622) removed their `from __future__ import annotations`: their __init__ signatures use ArcadeContext, which is only imported under TYPE_CHECKING. They can be recovered from git history if the work resumes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
arcade/texture_atlas/atlas_array.pyandarcade/texture_atlas/atlas_bindless.py.Why
arcade.texture_atlasdoesn't export them.TextureAtlasBase's 19 abstract methods, so creating one raisesTypeError.NameError: name 'ArcadeContext' is not definedon import. "Drop 3.9" (Drop 3.9 #2622) removed theirfrom __future__ import annotations, and their__init__signatures useArcadeContext, which is only imported underTYPE_CHECKING. Python 3.14's lazy annotations would hide this, and nothing imports these modules, so nobody noticed.They can be restored from git history if the array or bindless atlas work resumes.
Checks
atlas_array,atlas_bindless,TextureArrayAtlasandBindlessTextureAtlas: there are no references left.TYPE_CHECKINGwithoutfrom __future__ import annotations(including the WebGL backend, which can't be imported outside a browser) for the same kind of break, by parsing them: none have it.arcade.texture_atlasstill imports and exports the same names, andutil/update_quick_index.pyruns cleanly.🤖 Generated with Claude Code