Refactor PEP 661 sentinel handling to use a synthetic nominal class - #21894
Draft
edgarrmondragon wants to merge 1 commit into
Draft
Refactor PEP 661 sentinel handling to use a synthetic nominal class#21894edgarrmondragon wants to merge 1 commit into
edgarrmondragon wants to merge 1 commit into
Conversation
edgarrmondragon
force-pushed
the
sentinel-nominal-types
branch
from
August 25, 2026 17:21
d1c7eeb to
574e043
Compare
This comment has been minimized.
This comment has been minimized.
edgarrmondragon
force-pushed
the
sentinel-nominal-types
branch
from
August 25, 2026 17:46
574e043 to
0255ef7
Compare
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
force-pushed
the
sentinel-nominal-types
branch
from
August 25, 2026 18:03
0255ef7 to
785ebdc
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
I guess you want to cc @JelleZijlstra here. |
Member
|
If this fits better in mypy's model, I'm OK with landing it, but it feels worse to me. A sentinel isn't its own type, it's a single object that is an instance of the type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related