gh-109714: Omit redundant arguments when raising OSError subclasses - #156440
Draft
serhiy-storchaka wants to merge 1 commit into
Draft
gh-109714: Omit redundant arguments when raising OSError subclasses#156440serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…sses errno now defaults to the error code which corresponds to the exception class, and strerror is derived from it, so passing them explicitly adds nothing in _pyio, _pyrepl, multiprocessing and shutil. BlockingIOError in _pyio now passes the number of characters written by keyword, and FileExistsError in multiprocessing passes only the Windows error code, from which both errno and strerror are derived. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #156430, which makes the
OSErrorconstructor default errno to the error code of the exception class and derive strerror from it.With that in place, passing them explicitly adds nothing:
_pyioand_pyrepl.terminfodrop errno andos.strerror(errno), which is exactly what the constructor derives._pyioalso passes the number of characters written as the characters_written keyword argument, because without errno the third positional argument would be the file name.multiprocessing.shared_memorypasses only the Windows error code, from which both errno and strerror are derived.shutildrops the message which merely repeatedos.strerror(ENOTDIR).