[3.15] gh-156404: Restore the 'fullname' variable for .pth import lines (GH-156406) - #156431
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-156404: Restore the 'fullname' variable for .pth import lines (GH-156406)#156431miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
pythonGH-156406) PEP 829 moved .pth handling from site.addpackage() into StartupState._exec_imports(), and the local holding the path of the .pth file being processed was renamed from 'fullname' to 'filename'. Import lines in .pth files generated before Python 3.15 read that local, so they now fail with NameError on every interpreter startup. Inject 'fullname' into the frame which executes pth code, next to the 'sitedir' shim added for pythongh-149671. Reported downstream as karellen/wheel-axle#38 (cherry picked from commit 7f3d09b6e8018c3710dfde9f71c63d47a047beb1) Co-authored-by: Arcadiy Ivanov <arcadiy@ivanov.biz> Co-authored-by: Barry Warsaw <barry@python.org>
This was referenced Aug 26, 2026
warsaw
approved these changes
Aug 26, 2026
Member
|
@hugovk for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 829 moved .pth handling from site.addpackage() into
StartupState._exec_imports(), and the local holding the path of the
.pth file being processed was renamed from 'fullname' to 'filename'.
Import lines in .pth files generated before Python 3.15 read that
local, so they now fail with NameError on every interpreter startup.
Inject 'fullname' into the frame which executes pth code, next to the
'sitedir' shim added for gh-149671.
Reported downstream as karellen/wheel-axle#38
(cherry picked from commit 7f3d09b)
Co-authored-by: Arcadiy Ivanov arcadiy@ivanov.biz
Co-authored-by: Barry Warsaw barry@python.org