You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After 859c068 Doc/conf.py:24 sets _tkinter to None after import failure. To detect a future regression in local testing, should we add a CI or buildbot test that patches conf.py to _tkinter = None and then runs Sphinx doctest on turtle.rst?
To detect a future regression in local testing, should we add a CI or buildbot test that patches conf.py to _tkinter = None and then runs Sphinx doctest on turtle.rst?
I think we can leave this to a separate PR. We don't currently have any Buildbots that run any form of docs build, so this would need quite a bit of work in buildmaster-config, as well as someone to sponsor the machine it will run on. Adding it to the CI is also possible. But to be honest, I'm not sure there's a real benefit. Only we (CPython developers) run the doctests, and when we do it's usually with tkinter. I don't think the cost justify protecting against regressions here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these were fixed by 859c068, I presume these were added after when the CI built with tkinter so it wasn't caught.
Doc/library/turtle.rstdoctests are failing whentkinteris not present #111735