gh-156414: Document tomllib's limits & "extensions" - #156415
Open
encukou wants to merge 1 commit into
Open
Conversation
Documentation build overview
|
timhoffm
reviewed
Aug 26, 2026
Comment on lines
+172
to
+173
| Key/value pairs in TOML documents and tables are not guaranteed to be | ||
| in any specific order. |
Contributor
There was a problem hiding this comment.
Should this be something like
Suggested change
| Key/value pairs in TOML documents and tables are not guaranteed to be | |
| in any specific order. | |
| The TOML spec does not guarantee key/value pairs in TOML documents and | |
| tables to be in any specific order. |
As is I found it a bit unclear whether the unconditional mention of "Key/value pairs in TOML documents and tables" refers to the spec or the concrete impolementation.
hauntsaninja
approved these changes
Aug 26, 2026
hauntsaninja
left a comment
hauntsaninja
left a comment
Contributor
There was a problem hiding this comment.
Thank you! This is okay, but I feel like it still is a little "well you can do this if you want to", when I think we should probably want to mildly discourage people relying on ordering of TOML tables (especially given TOML's stance on the matter toml-lang/toml#162)
Comment on lines
+166
to
+167
| When writing portable TOML files, consider only using features that are | ||
| guaranteed or recommended by the standard. |
Contributor
There was a problem hiding this comment.
Suggested change
| When writing portable TOML files, consider only using features that are | |
| guaranteed or recommended by the standard. | |
| When writing portable TOML files, only use features that are | |
| guaranteed or recommended by the standard. |
we shouldn't hedge, this is the only way to be portable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.