Fix #864: preserve compound assignments when inlining - #866
Open
onuracar-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inline variable definitions now use the assignment AST to isolate the value and remove only the selected target or statement. This preserves sibling semicolon statements and remaining chained-assignment targets while retaining formatting such as outer parentheses.
Fixes #864
Checklist
Validation
.venv\Scripts\python.exe -m pytest ropetest/refactor/inlinetest.py -q(109 passed).venv\Scripts\python.exe -m pytest -q(2122 passed, 12 skipped, 5 xfailed).venv\Scripts\python.exe -m pre_commit run --files rope/refactor/inline.py ropetest/refactor/inlinetest.py CHANGELOG.mdgit diff --check